From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.175]) by sourceware.org (Postfix) with ESMTPS id C667338930CB for ; Wed, 29 Apr 2020 21:08:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C667338930CB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 199E9400C9267 for ; Wed, 29 Apr 2020 16:08:33 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id TtwXjsaO8Sl8qTtwXjHX8n; Wed, 29 Apr 2020 16:08:33 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PFlxA/zkFF9kBxCeUP2VhkKYHxyP28l9o1V6Mem5EHM=; b=S6AnJHV/fOiEt/XhrPAPHUhU8E +vV9DEoUAsC21EEjiBuEz3is80AI8Iv8VAwFpjUFQlkeyLJha8vwB3a3A6crWVQFrcwmKWPdH0aGv qEq1k9fcDtUzxFIJyj2SA0IdY; Received: from 184-96-229-138.hlrn.qwest.net ([184.96.229.138]:38964 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jTtwW-004CbH-S5; Wed, 29 Apr 2020 15:08:32 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 0/7] Make gdbarch.sh shellcheck-clean References: <20200428214655.3255454-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 29 Apr 2020 15:08:32 -0600 In-Reply-To: <20200428214655.3255454-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Tue, 28 Apr 2020 17:46:48 -0400") Message-ID: <878sie57an.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.229.138 X-Source-L: No X-Exim-ID: 1jTtwW-004CbH-S5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-229-138.hlrn.qwest.net (murgatroyd) [184.96.229.138]:38964 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 21:08:35 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> I ran shellcheck on gdbarch.sh and addressed all the warnings. It Simon> didn't catch anything serious, but I think it's good to have it clean Simon> anyway, so we can catch potential problems in future changes we do to Simon> this file. These all seemed fine to me. I'd like to see gdbarch.sh eventually go away entirely. Most of it could be ordinary C++ code. I don't have a concrete plan for this though. Mostly I've been reluctant to do it due to the amount of reindentation that will probably be involved, though I guess maybe I could write an emacs lisp script to handle this. Tom