From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 547333857C74 for ; Wed, 16 Sep 2020 16:02:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 547333857C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 34C8D56295; Wed, 16 Sep 2020 12:02:43 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yCvYlaaqROkU; Wed, 16 Sep 2020 12:02:43 -0400 (EDT) Received: from murgatroyd (75-166-96-88.hlrn.qwest.net [75.166.96.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id CC12756294; Wed, 16 Sep 2020 12:02:42 -0400 (EDT) From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Make target_wait options use enum flags References: <20200727173526.2186755-1-tromey@adacore.com> <87d02lafjn.fsf@tromey.com> X-Attribution: Tom Date: Wed, 16 Sep 2020 10:02:42 -0600 In-Reply-To: <87d02lafjn.fsf@tromey.com> (Tom Tromey's message of "Wed, 16 Sep 2020 09:48:28 -0600") Message-ID: <878sd9aevx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2020 16:02:44 -0000 >>>>> "Tom" == Tom Tromey writes: Simon> Good idea thanks. Tom> I'm going to check this in. Actually, I'm not yet -- the enum flags update pointed out a couple more spots to fix, and then while grepping to see if any other targets needed the same treatment, I found some other problems. So, this patch did end up catching bugs after all :) I'll send separate email about the problem I found. Tom