From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cIoxBmvQCWAREAAAWB0awg (envelope-from ) for ; Thu, 21 Jan 2021 14:05:15 -0500 Received: by simark.ca (Postfix, from userid 112) id 0DA811EF80; Thu, 21 Jan 2021 14:05:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A42211E939 for ; Thu, 21 Jan 2021 14:05:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6241A39540CC; Thu, 21 Jan 2021 19:05:14 +0000 (GMT) Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.194]) by sourceware.org (Postfix) with ESMTPS id 4F37C39540CC for ; Thu, 21 Jan 2021 19:05:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4F37C39540CC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 9D300173C1 for ; Thu, 21 Jan 2021 13:05:07 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2fGVlHnZJHPnU2fGVly79P; Thu, 21 Jan 2021 13:05:07 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PzuBvHYWQq7m5edBK8WINAdUrgMD2KbYhgNl25wVCHU=; b=S4oTQQtlmq4gYbyA1aXrRXVrbd YBFN728ChgZ0Oae/v0N4DuINBgAXrx/IpSb3XKTgJ92B5Y6n4PJ7fFps9HwYekLe91Zjfmphv5NsA wCryT2M2EluSBUjvbPYfd5xev; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:34474 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l2fGV-002644-1E; Thu, 21 Jan 2021 12:05:07 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdb: convert auto-load to new-style debug macros References: <20210121034032.113861-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 21 Jan 2021 12:05:06 -0700 In-Reply-To: <20210121034032.113861-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Wed, 20 Jan 2021 22:40:32 -0500") Message-ID: <878s8mw1p9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l2fGV-002644-1E X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:34474 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Function file_is_auto_load_safe was taking a format string and varargs Simon> just to output a debug print. This is probably because that function is Simon> used in linux-thread-db.c and main.c, but debug_auto_load is static in Simon> auto-load.c. I simplified that, making debug_auto_load visible outside Simon> of auto-load.c, and making the callers of file_is_auto_load_safe output Simon> the debug print themselves. Simon> The rest is pretty much standard. Simon> gdb/ChangeLog: Simon> * auto-load.h (debug_auto_load): Move here. Simon> (auto_load_debug_printf): New. Simon> * auto-load.c: Use auto_load_debug_printf. Simon> (debug_auto_load): Move to header. Simon> * linux-thread-db.c (try_thread_db_load): Use Simon> auto_load_debug_printf. Simon> * main.c (captured_main_1): Likewise. Thanks. This seems like a nice cleanup. I have one comment. Simon> - _("auto-load: Loading .gdbinit " Simon> - "file \"%s\".\n"), Simon> - local_gdbinit.c_str ())) Simon> + if (!inhibit_gdbinit && auto_load_local_gdbinit) Simon> { Simon> - auto_load_local_gdbinit_loaded = 1; Simon> + auto_load_debug_printf ("Loading .gdbinit file \"%s\".", Simon> + local_gdbinit.c_str ()); Some of these changes lose the _() wrapper. I don't know if we care for debug logging .. or maybe we actively want to remove them in this case? Anyway I thought I'd point it out. Tom