From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CMNVB6Hhr2CTRAAAWB0awg (envelope-from ) for ; Thu, 27 May 2021 14:14:57 -0400 Received: by simark.ca (Postfix, from userid 112) id 1C4A51F11C; Thu, 27 May 2021 14:14:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 508F81E01F for ; Thu, 27 May 2021 14:14:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E0806395BC36; Thu, 27 May 2021 18:14:55 +0000 (GMT) Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.49.180]) by sourceware.org (Postfix) with ESMTPS id 929BB395BC29 for ; Thu, 27 May 2021 18:14:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 929BB395BC29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 1D58412711 for ; Thu, 27 May 2021 13:14:46 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id mKWsl3FWaFRe9mKWslx9gH; Thu, 27 May 2021 13:14:46 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tNg1h1P+4S1BLiFWJ9AsPDOGnPDMduYLWpLCKemtKSY=; b=qwiIENLnginNuf48zo/yNs/8he qSgYHptt8hruM9Zy6mIUO9G1Lj9M1Oo5M/0VvgXtx4bjF4lKODS38h3sU+7aesGMk+G8et550mSvn CJXEAgzHte1qV2Wl1uKtfQ5z/; Received: from 75-166-146-111.hlrn.qwest.net ([75.166.146.111]:55368 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lmKWr-001pJt-Rs; Thu, 27 May 2021 12:14:45 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH 0/9] Convert breakpoint iteration macros to ranges References: <20210527153558.3016335-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 27 May 2021 12:14:45 -0600 In-Reply-To: <20210527153558.3016335-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Thu, 27 May 2021 11:35:49 -0400") Message-ID: <878s40t562.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.146.111 X-Source-L: No X-Exim-ID: 1lmKWr-001pJt-Rs X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-146-111.hlrn.qwest.net (murgatroyd) [75.166.146.111]:55368 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> This all started with me finding that the update_global_location_list Simon> function was hard to read, notably because the breakpoint iteration Simon> macros are a bit hard to read (require multiple local variables and Simon> pointers to pointers). So this removes all breakpoint-related iteration Simon> macros in favor of functions that return iterable ranges. This all looks good to me. I prefer external iteration like this when possible, as I think it's easier to understand and write. Thank you. Tom