Re: [PATCH] Make addrmap const-correct in cooked index

[Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> I suppose in this case we can consider that it's the DWARF code that is
>> broken, and that it knows the risks of casting away the const.  But at
>> least the addrmap code will be correct.

Simon> Or, if the client code legitimately wants to modify the contained
Simon> objects, then we provide a non-const version of addrmap::find that
Simon> returns a non-const pointer.

I was thinking about this weekend, and it seems to me that addrmap is
just a container and should be able to hold any type -- const or not --
much the way a vector does.  The issue on the gdb side is that addrmap
isn't templatized and so has to use void* as the type.  Anyway from this
view, using 'const void *' seems wrong because it moves the type buglet
from addrmap to the users of it.

Tom