From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aFwGIcpPI2Y8vjUAWB0awg (envelope-from ) for ; Sat, 20 Apr 2024 01:16:58 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=YOE7Xy56; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 823ED1E0C0; Sat, 20 Apr 2024 01:16:58 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6C95C1E030 for ; Sat, 20 Apr 2024 01:16:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 309F93858D37 for ; Sat, 20 Apr 2024 05:16:56 +0000 (GMT) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 8F31E3858D33 for ; Sat, 20 Apr 2024 05:16:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F31E3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F31E3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713590198; cv=none; b=FYCnimECPKSLFaxlTYNuzN31OWMyRQrPPv0SCPK7Z1T3HFPmCf0DNQZ67JZlQAgyezQRw79iCK2uVQtxC1amxNRvYT9d17quvnrOeV+RR5mah0NXTIjFDkCmSZL1mWZLFf6Did5oWgKEV07nuubOAKO7czHoEOuGc7q3aGFN1wg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713590198; c=relaxed/simple; bh=Vy7vb3Y1SVe5AizF/79ad1pREXhUZiCxCcea43tDzak=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wUE48zDNuRg4h/pWV/p/HYdQW5SoU+UUYlIYBMCSLp7Y8VytGaF23vhJdmmzeyFsaVyG4E17wxiDNR3nrlAsWihGbOfXkx7nxyKkCDUIcL4BbxaWz2TVw8oWaKlQmjzeWlr9pLwIg0Lh0Qxh5v4ikZPRM0L7jf77slwso8ePLBE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1e9320c2ef6so805415ad.2 for ; Fri, 19 Apr 2024 22:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713590195; x=1714194995; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Vy7vb3Y1SVe5AizF/79ad1pREXhUZiCxCcea43tDzak=; b=YOE7Xy56HpqBdPLjUIrbZ2QWj7Jl4edVxdEXwOAggL2B0jTGSiNUP8cw+eKUDL6+MB fczaPpBLf6lRU33kyNsQbsZbKrdrO91Y49uWx0t2RMm5SjadUPPh9DYEpV/Wy6mAFbCG w5/N7QIzYVOus84kcS141W6nvqg2IUazTlvgB1cV9Dn3rbxjzSPutLCdi4ceTCmEOlHK ilnybYKwDem+uHxY8y7x3U7buQqJhGLzpaukck9ZX5lryOwAIyaA5O/h67jJ8laEd4re bHGMJtNoL4yiJHn6R7T/Uw107u6aBwE33ZH1O8zGPWRXSk1WlLvPFVTkWjpFQmpGHBFk XGaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713590195; x=1714194995; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vy7vb3Y1SVe5AizF/79ad1pREXhUZiCxCcea43tDzak=; b=JQofQRaUai1kSP10dB3E09NnYzXy4ydE3geXbXEt4YgkqTmH3RCC5lOOtbMJ3WBcKD HWc/eSCC1GLCWVraq+R+Osr6EJlvolZsCXC9RIE0G1Bq+rACivGqsiBbG1iupb5a2M9r oEErs4TIxNABTQ4Lb+FmiKubVqmnE4Lkp2SfogzqBcFwHUO6cfzbBQ4UvWRxNtJCBX9D tXNRtHynqK8/bYV582NL9eeDVHrt+ugLSq6HPo1KmA/kkYmp03H8gafB1SDOqw8RL1K0 cVzKilTq7Jym3PWpWAAvV4ionTo0WwzkitAJBWTwCdc34yIT4krgNUyhlgil/ID8P5Fe hEfw== X-Gm-Message-State: AOJu0YxmxDBFccdCGJyDQ9pEYWyFlGx2qSd1kUY2uQa0gS6jLZWIN5iq fAtlYQ4zYGNmk/HyzjcgEucQGR+Q8iiNa1HyZEBzxhCyJ89e7C9SxMcOMBamPxo= X-Google-Smtp-Source: AGHT+IFgt5OJXNEIuKS4wczPBZBZzGw1MRs14Frb67greJrqCKmL+ESUTdKK+fdBfmyQuxOo4L7KLg== X-Received: by 2002:a17:902:cec4:b0:1e2:307f:d283 with SMTP id d4-20020a170902cec400b001e2307fd283mr5695332plg.1.1713590195599; Fri, 19 Apr 2024 22:16:35 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:1348:72c4:7c65:61e7]) by smtp.gmail.com with ESMTPSA id c11-20020a170903234b00b001e87c6aaf33sm4143269plh.76.2024.04.19.22.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 22:16:35 -0700 (PDT) From: Thiago Jung Bauermann To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFC PATCH 2/3] gdb/nat: Factor linux_find_proc_stat_field out of linux_common_core_of_thread In-Reply-To: <438f6f8f-ff05-464f-a63e-bdd2384fa371@palves.net> (Pedro Alves's message of "Wed, 17 Apr 2024 17:06:39 +0100") References: <20240321231149.519549-1-thiago.bauermann@linaro.org> <20240321231149.519549-3-thiago.bauermann@linaro.org> <438f6f8f-ff05-464f-a63e-bdd2384fa371@palves.net> User-Agent: mu4e 1.12.4; emacs 29.3 Date: Sat, 20 Apr 2024 02:16:33 -0300 Message-ID: <878r18k40e.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Pedro Alves writes: > On 2024-03-21 23:11, Thiago Jung Bauermann wrote: >> The new function will be used in a subsequent patch to read a different >> stat field. >> >> The new code is believed to be equivalent to the old code, so there should >> be no change in GDB behaviour. >> >> Also, take the opportunity to move the function's documentation comment to >> the header file, to conform with GDB practice. > > IMO, it'd be even better to move the new function to linux-proc.c, with a > linux_proc prefix. Done in v2. -- Thiago