From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4NWzFoOWwmZv+QsAWB0awg (envelope-from ) for ; Sun, 18 Aug 2024 20:49:07 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=X3RL/EEg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 49BA41E0D0; Sun, 18 Aug 2024 20:49:07 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 236871E0AC for ; Sun, 18 Aug 2024 20:49:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 148AD384DEE0 for ; Mon, 19 Aug 2024 00:49:04 +0000 (GMT) Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 6D2E63858429 for ; Mon, 19 Aug 2024 00:48:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D2E63858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D2E63858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724028525; cv=none; b=BFlOqmjm9W5m8KkwOTUZ2zYyIOAGBrSnoPhwdz3EkXnbCeTTkITed7NXG77OZUye1uQqLWYFgnABvTHDf+Fnz458KChzEsMR2qcigvqTcJyJWKdJKspIZEvAuwozqgqdhKUH/+kTOMWfYa2Afml93C5CzABeIS9m45Ck64LdgTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724028525; c=relaxed/simple; bh=hnNEwCClfQ2iiNThtMGtTZ74BNVm5cIWPkjNtPEdgpI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=C+km2qAuG9wcSfGNyuRSpoyAGvzPVuAdDbw1+mLWarZY0JiiFS5tycUeCtoUl95qBn6dXOwCj4KhVR/UVebkAo8Axt7fCn59527qEaICiOfnobnLg4p/D0Em528Gd1uxeosv+ASIetRWgAUR7r5LA0JfSe2DN71YktWoJNNJKGw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-7cb3db0932cso1010841a12.1 for ; Sun, 18 Aug 2024 17:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724028522; x=1724633322; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=2HM06TtLzVBGELkP6j4ZROUJkJ2j6W6IQcecxqj6I9o=; b=X3RL/EEgHSOWzK5uS0OKoQAWg5VqV88KXDVVcrcHHGzBfMDxc8ETA5ST4l953WXYm+ EIO6TBCMsIoPe0ohuDsZwB02RI8xbm4tmgni4vviiUPooH2wKTHiXkaSkPM0ddRBsBs+ hMb/HjCT8ivjuR0lUv34dZoCodI5sAriOETQajabGZUR7Ay1bW0ZLxGdlkZWX3+806Az 9V8G57nDJ1k4Aeh16PV6DiHaDR0sZZfhScjwNT0azeITzEJeosjB11WUlJy9ptIv52bB eVzxfYn2+u2aE7g8EPw32w3xa8EiTtkM4HyFrgQjPYd5GstC/bd0goPi3PjGuFoC5XS9 f9Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724028522; x=1724633322; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2HM06TtLzVBGELkP6j4ZROUJkJ2j6W6IQcecxqj6I9o=; b=cYMXS1H6olD+bMUYUT3wCyoQaF+i5n0yVe8KPjhbdxfDkCV4TwRZDbYcsN08U3W2Ie bw2uG5slHXc+ckmUamEgrH0t3Tk5OA7yamXxtWYXgbRHmc6tNzVIrauOuMjGD/5GFdC4 4vqEJW/QVurMXG7nOChTM6AG3dZ8B7XIOiL4hq3Jv2fgMNUxn4nIAnD2ItXtXssdQwRY 9eL/ZCWInxZPUpQTSlZzn3IIBhjrInNEpgIQeof+hbovia1z8FSb3Une0YxC+7MfDKCd YPWgjk+WhFCNfjcuIPM7SunlewoiaUNtdaXNvle9cCzzqNNpXdgJCTAsW2xIvacdd/DS pL/g== X-Gm-Message-State: AOJu0YzHbEX0T+gAl6Cq4pzEYVPE02bFx+UAjvtRzBLErUFoyi3nLJhG SBYmlsU52BEyK6Wnzaea4gCrE0GEGP6wwypOVwJeTylkCONXohZivr2QKSTxBRo0fsZYXQB0BrP e X-Google-Smtp-Source: AGHT+IHl2WmH/DLO4pztFhXyuPb+tAlXVJ1MpidxjCs+4VOnLzJq+xfhFCG7Tu11yz0fQMMDUaiFrw== X-Received: by 2002:a05:6a21:1706:b0:1c6:fbf3:a0ef with SMTP id adf61e73a8af0-1c905044f7emr11599576637.44.1724028522195; Sun, 18 Aug 2024 17:48:42 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:3d02:ac8e:9d51:e54f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201f0302e84sm54700835ad.32.2024.08.18.17.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Aug 2024 17:48:41 -0700 (PDT) From: Thiago Jung Bauermann To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Refrain from asking debug stubs to read invalid memory In-Reply-To: <20240318161955.668163-1-legouguec@adacore.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Mon, 18 Mar 2024 17:19:55 +0100") References: <20240318161955.668163-1-legouguec@adacore.com> Date: Sun, 18 Aug 2024 21:48:39 -0300 Message-ID: <878qwt9w2g.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hello, K=C3=A9vin Le Gouguec writes: > diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c > index 599a696839e..917c997ad8c 100644 > --- a/gdb/gdbtypes.c > +++ b/gdb/gdbtypes.c > @@ -2805,7 +2805,7 @@ resolve_dynamic_type_internal (struct type *type, > if (addr_stack->valaddr.data () !=3D NULL) > pinfo.addr =3D extract_typed_address (addr_stack->valaddr.data (), > type); > - else > + else if (addr_stack->addr !=3D 0) > pinfo.addr =3D read_memory_typed_address (addr_stack->addr, type); > pinfo.next =3D addr_stack; This can leave pinfo.addr uninitialised, so an additional branch is needed: else pinfo.addr =3D 0; The CI doesn't report any regression on this patch, so with the change above: Reviewed-by: Thiago Jung Bauermann --=20 Thiago