From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id S2XMGVEG12YSxx4AWB0awg (envelope-from ) for ; Tue, 03 Sep 2024 08:51:29 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=BEFBMYkX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 524011E353; Tue, 3 Sep 2024 08:51:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-11.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BA0FE1E08F for ; Tue, 3 Sep 2024 08:51:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5F39B386075C for ; Tue, 3 Sep 2024 12:51:28 +0000 (GMT) Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id CB9EE385DDCA for ; Tue, 3 Sep 2024 12:51:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB9EE385DDCA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB9EE385DDCA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725367869; cv=none; b=LfxD5Z/C06BquvA4pKFYXij9KwK/a5nUHkGXAlDf4UwU0NLOMdHcZiaUIHoszWu3AyxnOdscvouDBpWVzm5YcIUzSAQDTYRWHh5vDIyDCFEInTIeFjPU2RDszPlbgwfQHlTNOMGHk2ENfFKqPmuv6wuUSuGgi0VA3tvdhQPNYWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725367869; c=relaxed/simple; bh=lFdomqjZGAmREwmhqs6gNW44gJQ2midO8bohB3jSEeU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pIBx9HJyS2Jv6z99fxMNQu4ZU7biAB/nnsGQJCCnbU4PMlC0u5ZATyavKYVO9Yx4c2NmB9A8wMm3zYCz/EOwxc5xo3de2bU14Ba46e9OveeN5CyGXXVYUXq8KFNMS0afrO3bbqeIjG3DpZStdvib8kpkY+W2KjYkcVUpepQoWnw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-42bb6d3e260so44879145e9.1 for ; Tue, 03 Sep 2024 05:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1725367866; x=1725972666; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=znI5vXs+kLYAhwORyiZQMIvgdFt3Hplp5QdkESTqf54=; b=BEFBMYkXn7nY3Wfw8fE1j206oZ5urz4MuIAaXSNaqLOrF34RNe1eLXF7GYki1ssg+9 L7UsIy2FN9FVNVAkoyOKM6+STfvDjBjY/gQhj9u6Rc8xkaZ7Zmuzf0kzpzm35g0i1KSf gbIMz1Zk3nvXaj8ZMGIslAxxjeEDpM90jF/mavdePaGiyP1WHIn+erNxkMtru67ejVd1 P2jf5fhsB4gCM5lliD+PD7mlqLjV3O5jLD6RddkYZ1x/w7g3XmZSU+KDfXl8SqS0UCOr hb+S2y55/ZGrkG/maa1FE2ly6rzwiZ/QzQ3nRVWt2SgiBd0W+iRLRw6KRH2eGGK9DSvk eQBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725367866; x=1725972666; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=znI5vXs+kLYAhwORyiZQMIvgdFt3Hplp5QdkESTqf54=; b=QzfX6CGeqnPTJx88J20E3OgJnWVzlmbK9m1yDktAypfmgzPa9GoJ0Z2IC2PYgwz3px ZRsa9S71e0VNn66X9c1BmXEhTYOJhtOlMLv2yqTKfD4f0yepTa2xJQVEQ/RwB9M5ESsO 13Dg2sq9Z8Hz0a2YlrCtRSm0V73eq2pTcClMFqReJ+54rt9oWp/hAZU7yU/sO6gadDCD IUItgl7ejxku0IrEQ13NceLDy+PoCuxMZqtR3/fpqFYgPttRCzDPllENRtb7tVmfrqw+ XpKz0kgfJZl/4zaxRPm83+JMfM8HUkA8Q96PE0MlrG0Fw9cXkhI0vK3H7El1VD0Ey7iQ dOVg== X-Gm-Message-State: AOJu0YwoKnp6LHOcf7qu6BxOdkZ2nfJ0xDZzaRoFMuWbvQkf6wLSkamd JcPAex/vDXYEPxDVnrnBcLZCHggJ6cdshsBjiiMWj9tkA6pGi/ABD0e3jrLBF1rflBzcOIjMt8U = X-Google-Smtp-Source: AGHT+IGDn6Epydnukj0QWNekqwFqw0mvkUh404UsHnmsU+ElD1HnM1sWBFMMrnhJfAC8cjJNjMwTsQ== X-Received: by 2002:a05:600c:4eca:b0:426:5471:156a with SMTP id 5b1f17b1804b1-42bdc6334cbmr78942745e9.13.1725367865825; Tue, 03 Sep 2024 05:51:05 -0700 (PDT) Received: from legouguec-Precision-7550 ([2.57.72.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6deb239sm174571765e9.5.2024.09.03.05.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 05:51:05 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Refrain from asking debug stubs to read invalid memory In-Reply-To: <878qwt9w2g.fsf@linaro.org> (Thiago Jung Bauermann's message of "Sun, 18 Aug 2024 21:48:39 -0300") References: <20240318161955.668163-1-legouguec@adacore.com> <878qwt9w2g.fsf@linaro.org> Date: Tue, 03 Sep 2024 14:51:04 +0200 Message-ID: <878qw8529z.fsf@adacore.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thiago Jung Bauermann writes: >> diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c >> index 599a696839e..917c997ad8c 100644 >> --- a/gdb/gdbtypes.c >> +++ b/gdb/gdbtypes.c >> @@ -2805,7 +2805,7 @@ resolve_dynamic_type_internal (struct type *type, >> if (addr_stack->valaddr.data () != NULL) >> pinfo.addr = extract_typed_address (addr_stack->valaddr.data (), >> type); >> - else >> + else if (addr_stack->addr != 0) >> pinfo.addr = read_memory_typed_address (addr_stack->addr, type); >> pinfo.next = addr_stack; > > This can leave pinfo.addr uninitialised, so an additional branch is needed: > > else > pinfo.addr = 0; Quite right, thanks for catching this! > The CI doesn't report any regression on this patch, so with the change > above: > > Reviewed-by: Thiago Jung Bauermann No surprises on my end with your suggested amendment; will send v2 to the list momentarily.