From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id C1wlG4PNf2fNPwgAWB0awg (envelope-from ) for ; Thu, 09 Jan 2025 08:22:11 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=BZjnygbH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5EE631E0C0; Thu, 9 Jan 2025 08:22:11 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 83C9B1E05C for ; Thu, 9 Jan 2025 08:22:10 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E22EE3858C51 for ; Thu, 9 Jan 2025 13:22:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E22EE3858C51 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=BZjnygbH Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 2FAD03858D1E for ; Thu, 9 Jan 2025 13:20:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2FAD03858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2FAD03858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736428857; cv=none; b=aJMq29aP9FyMKT3Pfxffq+Z9NyetqZlHJ4d4CWg8bExxRFCpL9rYxOXrQub1X63yiSxSQDNd3RaV+d9fRXmGikI9QVAcrfTiIuqJFnrokPhFiHuUU2L9yEvjJKFb845dLIJjWuADw69kWnEzPCrkY6uI+CGmCLSa09zXGuBsB7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736428857; c=relaxed/simple; bh=+tNJkfikNn9bW7EUcGGOMS7a5myTNgNlIgW75ou/7W8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SblkdN8tac8WrEps8Cp+kQAaccUKYsgul+nXcOxREinVClHfU+9rCoI1vRpDAUl68NLBOYPwlz9kAgIu2Ny7KTrHFIBSXvKHc/sAzCVbyaCOn7cUx1KdENXzAXUIO0TBq9XyOgyKBFMngb3TKwjQk7Lfm3Z6ZVhz4hKYYk3A/lA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2FAD03858D1E Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5093qwkM005687; Thu, 9 Jan 2025 13:20:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=+n7WFpTJ8+NgR5rW7w5d1u1GMtb0D1 FcoZ9IHGa0sPA=; b=BZjnygbHuJJoHA1mAZ+WcCOJRS5d/INoj8sTsxMGg6ttcg N08n0ocIm0ZHC8XvfASd9Dxfr0A4JWdxBRizCCBy7qvu22w0+AsF7Gk1WJeqTDZv uQuDeRRi1gMMgPs+IbEmQMuNLUttKjZi2M8myX+ZtfTAuFNPbWYs2kBC0+QSuT27 wtvJma0Ve0BNnNqg5C44AACnobOajcwf2lG5Ndqhs080FZ/iwBBiqlXtlwkx9JUe jDAUAuxZEYyFGUjeEfgxyWIBuu+oacHbiyRmIfUlPJQVTKi0z0JBV57jzQ28/mHM cOKDaSbIcasVqcSHykgCizIF2g24ccUfvRlgdVqQ== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4426xca9pm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jan 2025 13:20:55 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 509CjMsn013645; Thu, 9 Jan 2025 13:20:54 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43ygap576d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jan 2025 13:20:54 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 509DKqXD49676716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Jan 2025 13:20:52 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C58082004B; Thu, 9 Jan 2025 13:20:52 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B03C920049; Thu, 9 Jan 2025 13:20:52 +0000 (GMT) Received: from li-07e5db4c-3052-11b2-a85c-815382633c95.ibm.com (unknown [9.152.222.94]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 9 Jan 2025 13:20:52 +0000 (GMT) From: Andreas Arnez To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/2] [gdb/tdep] Use symbolic constants in s390_prologue_frame_unwind_cache In-Reply-To: <20250109104406.30675-1-tdevries@suse.de> (Tom de Vries's message of "Thu, 9 Jan 2025 11:44:05 +0100") Organization: IBM Deutschland Research & Development GmbH References: <20250109104406.30675-1-tdevries@suse.de> Date: Thu, 09 Jan 2025 14:20:51 +0100 Message-ID: <878qrkrumk.fsf@li-07e5db4c-3052-11b2-a85c-815382633c95.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: gqjw5jYOTtsnQyTV9IrUDPmsKD2vTXCc X-Proofpoint-ORIG-GUID: gqjw5jYOTtsnQyTV9IrUDPmsKD2vTXCc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 suspectscore=0 adultscore=0 impostorscore=0 mlxscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=758 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501090104 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Tom, On Thu, Jan 09 2025, Tom de Vries wrote: > In s390_prologue_frame_unwind_cache there are two loops using a hardcoded > constant 16: > ... > for (i = 0; i < 16; i++) > if (s390_register_call_saved (gdbarch, S390_R0_REGNUM + i) > ... > for (i = 0; i < 16; i++) > if (s390_register_call_saved (gdbarch, S390_F0_REGNUM + i) > ... > > Fix this by using symbolic constants S390_NUM_GPRS and S390_NUM_FPRS instead. > > Tested on s390x-linux, by rebuilding. > --- > gdb/s390-tdep.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/s390-tdep.c b/gdb/s390-tdep.c > index 3a672b3869d..70affc914c2 100644 > --- a/gdb/s390-tdep.c > +++ b/gdb/s390-tdep.c > @@ -2532,12 +2532,12 @@ s390_prologue_frame_unwind_cache (const frame_info_ptr &this_frame, > ABI; for call-clobbered registers the parser may have recognized > spurious stores. */ > > - for (i = 0; i < 16; i++) > + for (i = 0; i < S390_NUM_GPRS; i++) > if (s390_register_call_saved (gdbarch, S390_R0_REGNUM + i) > && data.gpr_slot[i] != 0) > info->saved_regs[S390_R0_REGNUM + i].set_addr (cfa - data.gpr_slot[i]); > > - for (i = 0; i < 16; i++) > + for (i = 0; i < S390_NUM_FPRS; i++) > if (s390_register_call_saved (gdbarch, S390_F0_REGNUM + i) > && data.fpr_slot[i] != 0) > info->saved_regs[S390_F0_REGNUM + i].set_addr (cfa - data.fpr_slot[i]); > > base-commit: 42bcf692abd52ec1cb9d4bf3eca545e3b33fe536 This is OK. Approved-By: Andreas Arnez -- Andreas