From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id y/omFedlN2i5PzgAWB0awg (envelope-from ) for ; Wed, 28 May 2025 15:37:11 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=aV2WxoOo; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 474741E11C; Wed, 28 May 2025 15:37:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BD7191E102 for ; Wed, 28 May 2025 15:37:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 449FB385C406 for ; Wed, 28 May 2025 19:37:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 449FB385C406 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=aV2WxoOo Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 8305C3856DFA for ; Wed, 28 May 2025 19:36:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8305C3856DFA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8305C3856DFA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748460998; cv=none; b=spPmkzcIX0knIjs32LxatuwAqKuOjiXxcy5lGY1fyzz8nYpICn33igrvXlpeZhOKIbsg9ecZs17e3P7zr3bdHS8ww/SQTG8q5TnKzpqm866KraNUUofTzYLRcC2dcv9ZF4cAf4rsv0pbit9PBjXf54/n+MOnYAEURcyaTa5UuPY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748460998; c=relaxed/simple; bh=Pb1RbB0kzuTFTcbYGQSI8jwRb9wBHkK2oHgKMCDsWEA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=gD6AdN9kIxEaYWSHx9Obv/E3nlrou+kv2txDsXjItdm3wTu64Mm4V6/bNj/Rye0t/qzjO16JsKw12xBsaLn4WW6GYsnTBLnGMQzDVf7PoVKhCQIsG0mxK1Da7ZBVf1r2P79tz5OXJ9hjfEbunVin7smHh7duDz7g9awsWYL2jcI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8305C3856DFA Received: from eig-obgw-6010a.ext.cloudfilter.net ([10.0.30.248]) by cmsmtp with ESMTPS id KHfvusd3AAfjwKMZpunEfL; Wed, 28 May 2025 19:36:37 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id KMZpueFoRhHAkKMZpuWMik; Wed, 28 May 2025 19:36:37 +0000 X-Authority-Analysis: v=2.4 cv=YsIJRZYX c=1 sm=1 tr=0 ts=683765c5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dt9VzEwgFbYA:10 a=ItBw4LHWJt0A:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=orc2Ag_w-2uoGXWzTM0A:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FoLXpFHvI9iR1sg+U+Nly5sZ8QsXHwOPZU7yod2TCvs=; b=aV2WxoOoZdeN/715V4pzJRpXTU U2tjpLkTAwfts2vcS9HxIbIvkuPNm6Of2Da/8t9SG+q+b4hyiFVZvueLYlixTINYDWLMufyhr553e hPO0OAKfohRZDo2916fCYX6gp; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:42616 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uKMZo-00000002mUB-1ulB; Wed, 28 May 2025 13:36:36 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 31/47] Windows gdb+gdbserver: Eliminate struct pending_stop In-Reply-To: <20250519132308.3553663-32-pedro@palves.net> (Pedro Alves's message of "Mon, 19 May 2025 14:22:52 +0100") References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-32-pedro@palves.net> X-Attribution: Tom Date: Wed, 28 May 2025 13:36:34 -0600 Message-ID: <878qmgfry5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1uKMZo-00000002mUB-1ulB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (bapiya) [97.118.46.156]:42616 X-Source-Auth: tom+tromey.com X-Email-Count: 20 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBs2ZlrXI7GgVjbdlPOYSUgZtwDdm4bgCev0nNmhwTzyUdXA8tRjLZmG79l+cKpy5gh7tze6w/xKaUzoF4/h+L/YF2vK7FNTeM+9RMtC33uhnSrBv4xj eIHOb5bcUv7kX3hYeQhBB1rU8FAMge4ywPcHYjc+hyICp+aFyh0xVxbG/EofR4vVyNgjtg/e9O1WUMCXApyneC/HI3zlJg20d4k= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> After the previous patches, struct pending_stop only contains one Pedro> field. So move that field into the windows_thread_info structure Pedro> directly, and eliminate struct pending_stop. Nice, thanks. Pedro> @@ -112,8 +102,11 @@ struct windows_thread_info Pedro> effect of trying to single step thread A -- leaving all other Pedro> threads suspended -- and then seeing a stop in thread B. To handle Pedro> this scenario, we queue all such "pending" stops here, and then Pedro> - process them once the step has completed. See PR gdb/22992. */ Pedro> - struct pending_stop pending_stop {}; Pedro> + process them once the step has completed. See PR gdb/22992. Pedro> + Pedro> + TARGET_WAITKIND_IGNORE if the thread does not have a pending Pedro> + stop. */ Pedro> + target_waitstatus pending_status; I think this comment needs a minor update. There's no longer a queue of pending stops, just a single potential pending stop per thread. And, I suppose now the thread's last-event object has the relevant information about the pending stop, so maybe the comment could mention that as well. (I mean, I suppose it should be obvious from the context but it doesn't hurt to be explicit.) With that update, though: Approved-By: Tom Tromey Tom