From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EFVhNI4hemj6VBcAWB0awg (envelope-from ) for ; Fri, 18 Jul 2025 06:27:26 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WRPqv2p/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D0C631E11C; Fri, 18 Jul 2025 06:27:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3A37B1E0C2 for ; Fri, 18 Jul 2025 06:27:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BAA57385E443 for ; Fri, 18 Jul 2025 10:27:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BAA57385E443 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WRPqv2p/ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id C606F3858C60 for ; Fri, 18 Jul 2025 10:26:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C606F3858C60 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C606F3858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752834409; cv=none; b=anGWndZzUo3I0ErxvxAsvKam9gIRTzGuV1ConrZIt+1HOAk6WwdFcaeLm3K6UiAEKsnvcBr6wsDZ/OrEpRIg3wNEw/y/iXZhFqgMwVUgCY76+m+smqJ4UXRcbhd1bfpe6bUnsa+BLna72ZoK90p+lIQHmdZY9N+i6RwMK49cRT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752834409; c=relaxed/simple; bh=OnPDtfmgZvDVCnghM6Tgd0B2e7tNhEi1vqfG5T4k7aQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PIG7Ymat5P4ry5tjMZVQi6Y13pPtUES1mztAUru+93gFBUO14pKObcC+RPRqofDjnks4GuexIMvC0x8LfTRd2qvPnhGLyWP1qhBXpT6edrFQKezWPB4a/sdp7WbwEqG1rkIfSMvnpxFNHbVupvsizDHNoVLh9CCieVxoza3mdE0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C606F3858C60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752834409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NTjAdBk5wk2bnCOXL/s+l2vRdUZ7u9486Yn8uSef+0E=; b=WRPqv2p/FarSXnSQkIKEkhcaF12GvRY1cMnHfnl+3YC3WuIYYa/DhuDPLsN027BVfAjeGB EfKqOxMfvgsH2ad9jmGJTw8zuKS2e9kEQHkShmTSX/kbkpjmZdFjBUHX+0OuufEf6e+gko IfYlAqlwWab/B27LmaTVebdRY37IXCQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-1flwYVZONcWj8qQNMcYssg-1; Fri, 18 Jul 2025 06:26:48 -0400 X-MC-Unique: 1flwYVZONcWj8qQNMcYssg-1 X-Mimecast-MFC-AGG-ID: 1flwYVZONcWj8qQNMcYssg_1752834407 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-454dee17a91so15601575e9.3 for ; Fri, 18 Jul 2025 03:26:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752834407; x=1753439207; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NTjAdBk5wk2bnCOXL/s+l2vRdUZ7u9486Yn8uSef+0E=; b=VxUPb82NX2Tfc862JEPtgWxzNp8S6ZK8u7HrIGZPPQTjYHC5quhpq3ePPp150m4bT4 rwFfYdFj7xNC6WWLjO+i+JoGG/FKt+iS66yq7gqxEEbetesEkRqXzB6QOq3oTp3sb1y0 +Fa+0HDYSMOMIkKxZBXK/JBzoSGqkTeOGcuwau+e+l6MIM9RXfyEsQ50mZARmGs+VLID Tamyof6BtIS0zl/iKoDFG/rjFi7vzsy9Zlk+c13VXdbp0OO6SP5eHsrZdELarWKVAYK7 IsLwn6p6+cyUGuMty7oGugbM0y9ElDcn6/bLoRIUFn7jFyumGiegqM7vHcit6bjUmg4A AVUA== X-Forwarded-Encrypted: i=1; AJvYcCXp9HxTBE28L6BA7qsjocnRhrbe6hTVUWm+Ppvgc0cPf7tG7ZWMKD4Ayz20xNDPYxqP6paJcAPXPM7GAA==@sourceware.org X-Gm-Message-State: AOJu0Yzbj50/mUaioCkZxK2n4b2lVlXvEZBj1RQdLG0YvzXKLf7JjbQP /ULX53Kh+n1qk0SoQMLA6oqnbBiTnMfSjmfwJctzMEEJBvmnxrUhs5n9fVMlU0jsSlX4IuOA4p+ KZTRem+3G8TwmXfj1TX/Pujf1JsI/aqC5JapJPxtwFrSj69uZTTh+wQJ0xQGkXSEduZXJyVA= X-Gm-Gg: ASbGncucajtn1gKoDijQTMfffXuBXHOgzShAWlvT4luq3F9C95hGKBgXWfBVp/Rd/7r rInzWqw8hm5HX/kWyJphXu2cgx82CpI21a39rCda5D7v9pb4SwsUCvT+czlsNKWz+VNYVFOtQsy aR1/qd5HeCtP5ZO8XimSswOZnXj+EeeVTJfnzUGPcXiTBbhjvAOYzOBT5ulN/QoJkmeX9kFO6Fv OgyK2ACccDKTU3YWrj2VzTeGAvkpTCJuIHP+I5YVRIo/8vfhvVrCqTPX4zaVdbeCtUHY5Lh8zZx h/65F4sn8/izWi1CjsfCXsRI9iIYHkHdjdtrMQywEo7WU366c/0zeHCLEJ+dv70u X-Received: by 2002:a05:600c:4588:b0:456:2ac6:ccb7 with SMTP id 5b1f17b1804b1-45633afc5d9mr69531555e9.11.1752834406853; Fri, 18 Jul 2025 03:26:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEh3zONlE3qKflvzUO62uvCTDsF/Qcz+KJZr+zmYS+8oJ/AFYe0uNVrpGCBC02tgx0ViVVVag== X-Received: by 2002:a05:600c:4588:b0:456:2ac6:ccb7 with SMTP id 5b1f17b1804b1-45633afc5d9mr69531335e9.11.1752834406296; Fri, 18 Jul 2025 03:26:46 -0700 (PDT) Received: from localhost (75.226.159.143.dyn.plus.net. [143.159.226.75]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca5c8c9sm1427856f8f.85.2025.07.18.03.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jul 2025 03:26:46 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: mark the start of each gdb.in.* log file In-Reply-To: <47c67727-2c45-403d-9a72-4d38eb4062e1@simark.ca> References: <645cd54b3add6e39d3c8ba69e15c0a85bd0875c4.1752689517.git.aburgess@redhat.com> <47c67727-2c45-403d-9a72-4d38eb4062e1@simark.ca> Date: Fri, 18 Jul 2025 11:26:45 +0100 Message-ID: <878qkllrq2.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VSslmqtoNIS0OkKsNZGrVg9mGWyQAOeWkt3v12ALNX0_1752834407 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > On 2025-07-16 14:12, Andrew Burgess wrote: >> Emit a line in the gdb.log file each time a new gdb.in.NUM command log >> is started. The gdb.log line includes the full filename for the new >> gdb.in.NUM file. >> >> This change will make it trivial to go from a FAIL in the gdb.log file >> to the gdb.in.NUM file that (should) reproduce the failure. When I >> encounter a failing test one of my first steps is usually to identify >> the gdb.in.NUM file and try re-running it to see if that reproduces >> the failure. Some test create many very similar gdb.in.NUM files, so >> finding the exact one can sometimes be difficult. With this patch >> that task is now trivial. >> >> There should be no change in what is tested after this commit. >> --- >> gdb/testsuite/lib/gdb.exp | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index 777d64d14d1..78356bf51f0 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -9990,6 +9990,10 @@ proc gdb_stdin_log_init { } { >> >> set logfile [standard_output_file_with_gdb_instance gdb.in] >> set in_file [open $logfile w] >> + >> + verbose -log "" >> + verbose -log "Starting logfile: $logfile" >> + verbose -log "" >> } >> >> # Write to the file for logging gdb input. >> >> base-commit: 1edefea39ff27ed2d4aed4e45ed416f3fbaf6098 > > Sounds like a good idea to me. > > Approved-By: Simon Marchi Pushed. Thanks, Andrew