Re: [PATCH] gdb: include NT_I386_TLS note in generated core files

[Andrew Burgess <aburgess@redhat.com>]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andrew Burgess <aburgess@redhat.com>
>> Cc: Andrew Burgess <aburgess@redhat.com>
>> Date: Tue, 23 Sep 2025 18:31:46 +0100
>> 
>> 
>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=15591
>> ---
>>  gdb/NEWS                                      |   4 +
>>  gdb/amd64-linux-nat.c                         |  26 +-
>>  gdb/doc/gdb.texinfo                           |  11 +-
>>  gdb/features/i386/32bit-linux.c               |   7 +
>>  gdb/features/i386/32bit-linux.xml             |   5 +
>>  gdb/i386-linux-nat.c                          |  21 ++
>>  gdb/i386-linux-tdep.c                         | 171 +++++++++-
>>  gdb/i386-linux-tdep.h                         |  15 +
>>  gdb/i386-tdep.h                               |   5 +
>>  gdb/nat/amd64-linux.h                         |  29 ++
>>  gdb/nat/i386-linux.h                          |  10 +
>>  gdb/nat/x86-linux.c                           |  44 +++
>>  gdb/nat/x86-linux.h                           |  15 +
>>  gdb/testsuite/gdb.arch/i386-linux-tls-regs.c  |  74 +++++
>>  .../gdb.arch/i386-linux-tls-regs.exp          | 314 ++++++++++++++++++
>>  gdb/x86-linux-nat.c                           |  67 ++++
>>  gdb/x86-linux-nat.h                           |  17 +
>>  gdbserver/linux-x86-low.cc                    |  99 ++++++
>>  18 files changed, 928 insertions(+), 6 deletions(-)
>>  create mode 100644 gdb/nat/amd64-linux.h
>>  create mode 100644 gdb/testsuite/gdb.arch/i386-linux-tls-regs.c
>>  create mode 100644 gdb/testsuite/gdb.arch/i386-linux-tls-regs.exp
>
> Thanks.
>
>> 
>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index 8be367d2424..b7f99551927 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -87,6 +87,10 @@ single-inf-arg in qSupported
>>    In systems that don't support linker namespaces, or if the inferior hasn't
>>    started yet, these always return the integer 0.
>>  
>> +* The 'org.gnu.gdb.i386.linux' target description feature can now
>> +  contain three additional registers which provide access to the TLS
>> +  related GDT entries on i386 (and x86-64 when compiling with -m32).
>> +
>>  * Add record full support for rv64gc architectures
>
> This part is okay.
>
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -50207,8 +50207,15 @@ i386 Features
>>  @samp{ymm0h} through @samp{ymm15h} for amd64
>>  @end itemize
>>  
>> -The @samp{org.gnu.gdb.i386.linux} feature is optional.  It should
>> -describe a single register, @samp{orig_eax}.
>> +The @samp{org.gnu.gdb.i386.linux} feature is optional.  If the feature
>> +is present, then it should describe the 32 bit register, @samp{orig_eax}.
>> +
>> +Additionally, the @samp{org.gnu.gdb.i386.linux} feature can optionally
>> +contain three 128 bit registers called @samp{i386_tls_gdt_0},
>> +@samp{i386_tls_gdt_1}, and @samp{i386_tls_gdt_2}.  Each of these
>> +registers contains one 16 byte @samp{struct user_desc} (see @samp{man
>> +2 get_thread_area}) object which describes one of the three TLS
>> +related GDT entries.
>
> Suggest to use @kbd instead of @samp when showing the man command
> line.

I've fixed this in my branch.

Thanks,
Andrew

>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>