From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mBwzGg4vq2mbXRkAWB0awg (envelope-from ) for ; Fri, 06 Mar 2026 14:46:22 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=hXN3Z34a; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 566161E0DD; Fri, 06 Mar 2026 14:46:22 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A095D1E089 for ; Fri, 06 Mar 2026 14:46:21 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id EE72A4BA23FD for ; Fri, 6 Mar 2026 19:46:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE72A4BA23FD Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=hXN3Z34a Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id BF14C4BA23CF for ; Fri, 6 Mar 2026 19:45:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF14C4BA23CF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF14C4BA23CF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772826353; cv=none; b=jL6XHIJVN8jS45pXAVG4VzjZI0qIuWSXfy2jqBCUYGHiG1NCgIL1DpLPwnL6VwC1nbUBnpeThZH43uIKcLnhEU/lOdRGInNWYlb26rzqFIRCFMLK7rr9VsmhvdsZmNfHby9KVaFxFw+Q0lWER9sMZvtHiCZV+4VNzG6oyt/oZK4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772826353; c=relaxed/simple; bh=ldYtiEn2RfVGLRFz5ZPrBqWxMHcg8BKe0QLGcYNCq5U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kdcHtUSw7RgoG6Vey4CzKe1yKlYa0HGqwmPJGoJWYp8kbejsiHSCHVZqViZzr8q01oaqsDfesJ6CqDMN/84yLO1ymSAsfgGFPfyNwkJeSKxS75WYfNNJECGhheynQ0T9GEDgi2q7zBqze1id6TdWEMl1wLvHKs2L+vmyd98hOUM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BF14C4BA23CF Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id yYdtvQPBqSkcfyb7RvRNux; Fri, 06 Mar 2026 19:45:53 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id yb7Fvw66EjAxuyb7GvTwDv; Fri, 06 Mar 2026 19:45:42 +0000 X-Authority-Analysis: v=2.4 cv=EoDSrTcA c=1 sm=1 tr=0 ts=69ab2ef1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=iv4SiOv2kOSn29LyGNwA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=o97dwUdKmEsCTilIwUdlqZSfMVeC+SgZsls9XbQZ+DM=; b=hXN3Z34a2X+RE/3jOcfyF5ih3B 4aceatvNM7iQiC+o8tXS69I8fP4vm0KK9CvUZhPPRVgva8hWk7sb69LXDVu5V/EhXMLdg3jRXvZW1 cuCWFYqYlU8bNYFOOgkDLF996; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:56208 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vyb7F-000000005fV-1jht; Fri, 06 Mar 2026 12:45:41 -0700 From: Tom Tromey To: Matthieu Longo Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 4/9] gdb: add new helpers for retrieving a type's fully qualified name In-Reply-To: <40f9c944-66e7-4a6d-8b86-80c7796feb6b@arm.com> (Matthieu Longo's message of "Fri, 6 Mar 2026 17:49:09 +0000") References: <20260303161659.397427-1-matthieu.longo@arm.com> <20260303161659.397427-5-matthieu.longo@arm.com> <877brsrb7o.fsf@tromey.com> <40f9c944-66e7-4a6d-8b86-80c7796feb6b@arm.com> X-Attribution: Tom Date: Fri, 06 Mar 2026 12:45:40 -0700 Message-ID: <878qc4yc63.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1vyb7F-000000005fV-1jht X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:56208 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJfF3NhJM9S2LR05XlQ07JTkpyHy+5UNGhXxBFvAc+u/pW+BN88rhCGZ6pEnZ2UP1SlzaNJMnBBxCRc2C0IeNYetu9i30YN6rn2Q9TP3JzI4KrH9Ne6V t71/YnSEBJ6eOTHjff3j+fJM6Nphb4AaKg13cR6L9NPHgNzJLF1WAlTYFJeinWpPFnVt/nTyeYjsNQJ2B42+ZhGvRsgqESIGjk4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >> I think this case can't actually be hit... can it? > It currently can when you build GDB with python 3.11 for instance with > --enable-py-limited-api=yes. Unfortunately, I haven't added the logic > to error when someone requests to build GDB against the limited API, > but does not have a suitable version of Python. This #error were a > workaround to provide a meaningful message to the developer in this > case. Ah ok, I see. I guess I was assuming that we'd get an error from "somewhere" (Python I guess) since gdb would be requesting a limited API with a version newer than what's available. > Here is the fix to remove #error macros, and detect the issue at configure time. > I will split the configure fix from the removal of the #error macros in the next revision. > + # The choice of the minimal version for the Python limited API won't be > + # frozen until the end of the migration. > + AM_PYTHON_CHECK_VERSION([$python_prog], [3.14], [ > + AC_DEFINE(Py_LIMITED_API, 0x030e0000, > + [Define if GDB should be built against the Python limited C API.]) > + ],[ > + AC_MSG_ERROR([Python limited API support requires at least Python version 3.14]) > + ]) > fi Seems reasonable, thanks. FWIW for a speciality configure option like this, I think it's also fine to bail out at build time, like just a check and a #error in python-internal.h. But configure failing is definitely a bit friendlier. thanks, Tom