From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bMp6EJfCB2o7Uz4AWB0awg (envelope-from ) for ; Fri, 15 May 2026 21:04:23 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZsZj2XEf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2A0471E067; Fri, 15 May 2026 21:04:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0576C1E067 for ; Fri, 15 May 2026 21:04:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A4BF4409FCBB for ; Sat, 16 May 2026 01:04:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4BF4409FCBB Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZsZj2XEf Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by sourceware.org (Postfix) with ESMTPS id 7C4E64BA798C for ; Sat, 16 May 2026 01:03:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C4E64BA798C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7C4E64BA798C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::831 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778893435; cv=none; b=HnYj2k6rJAQQHPGSZxLuBWemFfFRUabYhwvC7G9uNts9owX4YlkonkKr/40c/8szy/LVRYWzmbV6nz4E/6VeKI3OLCTXPrOVbUvXnzxjpM28NN9Es64pZk5itvtJurF5yEmLvJpBwGRm/a0AWIOPaT/2zbPOuS5bN0YY/3Myjpg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778893435; c=relaxed/simple; bh=fdihijyU635egNnGnIrz4rxdYSaYfvyXA2732SaCi9c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XBtOoBTYfClSxcSy6uusaC/pvX49WJh47k7+WYmV1yGEzzwbIHI+mjhf/3CzRvDE3TKt2+oVEVJQZPcFlYyBjo4JgfPLNpkU8T7tlDS0tzl2gBJUBTk4VVwTJArGM93QYX4vrc7OHre8mY6vrlYPNR9X2vQCvXivxywwq/DIJFk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZsZj2XEf DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C4E64BA798C Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-5165195c8b0so7549441cf.0 for ; Fri, 15 May 2026 18:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778893434; x=1779498234; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=LHIggLgiaRwxayTBYLFqbg4flmlcyaYfJ1yIWYVUJtM=; b=ZsZj2XEfGo4YpyYwK/AzmjcVbk6T1VchxCFsU9RI3jAlXoUzXB2XJk7rqrdoBvsNqe Bk7KvY6P2u9cohmwMUtEDjGJyo8aj/WISNucnRt4h+dsvSqSef58P8P/6rM8wau1wDUV GtlTU2WfwT0evfLi2bSZeueEjSDivw9P824NY5kMXBQrka6KJIulDtE4BV26YGbrn5bG t4yIOZxDgGGbtmQZZMRGqeKzwGK1PgZaHWh65RxSOeuNnAInlErJjyeNvzxCE67o519Z YxdovTyQV4iA//NMBibcTFfo44YsFJjwxaiqIdks5973+pS3gABdjJ36peNIGELRH9Rr DFmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778893434; x=1779498234; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LHIggLgiaRwxayTBYLFqbg4flmlcyaYfJ1yIWYVUJtM=; b=Aq8a81eC0/t2ZdCI/QkFap5FJNCd7cN/dgIQaykj0YGlB/eWFzEpofkTVTqd9XfVZp cQRegyCpPkLP1NeUYROAU6e5vavwvfLdwus8ViT+GGfhN1n1feLjBBwgcArDlS/IjglP 3CUsQ0uK1bi6Lr+BzVBL4SgZkOFyIot0dWmkHAsZPSEzNvZM2xhlK+sVMAxbyLgnoChn R6XyM9OHPPOM0bRkF5rVW0XNebSLByV6vbi1IoZYTXYzmKXXO8UbbOZsJPgh/xyAQZ9I s9l5jC8D2aoBs9QMr2QMvb6iw9eqS/zxQff4vpM8BlyGhSJ6N2y924okSvyxNiYd0du5 CPFQ== X-Gm-Message-State: AOJu0YzeZnyRqG4uTXCcqJ4JKftj96jmWuPsQijSaYo/OdYTTB2zXs+6 4/wByLVngs0vXG30xAm73c809pfJ0OgbbFJVDwuNHmz0dkKos9PcvpV8Gss0ePpM1PspLvWGYQO szPnr X-Gm-Gg: Acq92OEpIanvC3wzRoNsUTjIbo872NFrWQl857xM6RZ+lVtrYS7NLtHPNTB2ootV/ey qY9ERSd/GxaEvFCrCrUJ1bzJbeYEHQKVAcA8JsMSEvWNif++MFCxkp5TUsjWd97ml36vyhK6FQ+ HRFdolQMtk6IIWwxUTAJaz20jTD0zDyr7bi+uZEeFCHgyoLdAH5zX90AXLfn7jq2cMSDTwKRxID Mxxr6/uUQUSu8XPRlybvgNNnwfADYlYkPQQ9fZGbTMSZkYOyf2+SaDj3Hd6BL5J411srKdJe3eO agHxNz9ZueWmGPp03qYgw/8uITa3LJqM5hLvOBUroJPTZA97nVoZjTCld+QSbM7jIT0GBpppBr1 V7puUwdzequxUD0Pn/AEeieetYHXtvLw5lcrz2490wws4SZMpdsRs2rYAQYcvcXOFD+QO/zXjr2 lfdhaZlga65bAltrCaPPxBmrn5lAmcpGCi/g== X-Received: by 2002:a05:622a:145:b0:50f:b17d:7e53 with SMTP id d75a77b69052e-5165a20ddb8mr92044841cf.47.1778893434352; Fri, 15 May 2026 18:03:54 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8c90bb82a92sm68390796d6.36.2026.05.15.18.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 18:03:53 -0700 (PDT) From: Thiago Jung Bauermann To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 4/7] gdb/record: make record_full_history more c++-like In-Reply-To: <20260515163706.3355686-5-guinevere@redhat.com> (Guinevere Larsen's message of "Fri, 15 May 2026 13:37:01 -0300") References: <20260515163706.3355686-1-guinevere@redhat.com> <20260515163706.3355686-5-guinevere@redhat.com> User-Agent: mu4e 1.14.1; emacs 30.2 Date: Fri, 15 May 2026 22:03:51 -0300 Message-ID: <878q9kyxl4.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hello Guinevere, Regarding patch 3: Nice that you were able to turn the cleanup functions into destructors! Guinevere Larsen writes: > Move some functions to being a method of record_full_history, instead of > floating functions. > --- > gdb/record-full.c | 25 +++++++++++-------------- > 1 file changed, 11 insertions(+), 14 deletions(-) Regarding this patch: Reviewed-by: Thiago Jung Bauermann -- Thiago