From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hCeyJvLMDWq/ZgoAWB0awg (envelope-from ) for ; Wed, 20 May 2026 11:02:10 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FBtFz/hv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8BD551E098; Wed, 20 May 2026 11:02:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 91BCB1E024 for ; Wed, 20 May 2026 11:02:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 713424BB58E4 for ; Wed, 20 May 2026 15:02:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 713424BB58E4 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FBtFz/hv Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 19A224BB5917 for ; Wed, 20 May 2026 15:01:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19A224BB5917 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 19A224BB5917 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779289293; cv=none; b=CITS5+KkCRxjTudZa3T77+p8+IsFbR1IsI8tHCIAEab/RRjHq7qxrTtZmwONKrI6ppz5tFxkXBGOoqsjSZmIK4QKEHp7i6fEkMPudo+N2m3h2/UNb8hjCscJh09JlRnNf8CyY5+xUcnOdoopIFhsJrzAkijEjyerhLNIiljIhk8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779289293; c=relaxed/simple; bh=AGJ0dHewookK//YHLzQdURphH/+KWC3R+xyGKXZSeOE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DMxzckfo1VxROhmBihPRlXo2kTrOV4Skv1T8opvCall44Cx7X01sM3CHgxlMFLsZNPimEbjoDQewiSR7X+x8/T79qKyrAaFCgrVZkDTOiSLqN1oWsQJKEKJH6ReYHJaBN2V4vMvEc8aRjTrP1lAdYhFdFemgqckUtw20mlk9sJ4= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FBtFz/hv reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 19A224BB5917 Received: from eig-obgw-6001b.ext.cloudfilter.net ([10.0.30.143]) by cmsmtp with ESMTPS id PiCrwo5ckKSRRPiQOwlWH7; Wed, 20 May 2026 15:01:32 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id PiQNwCRzbnDcjPiQNwXEg5; Wed, 20 May 2026 15:01:31 +0000 X-Authority-Analysis: v=2.4 cv=BLizrEQG c=1 sm=1 tr=0 ts=6a0dcccc a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=zstS-IiYAAAA:8 a=t6Y1IIFiZDXr5bJU7HsA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QN2u61sR7UiSzXS858U7HyfE7Pl1rHT4U+cokAlVX/8=; b=FBtFz/hvM6X0NaTigSgxJjQDoK TPnb2HpUj6OyjcMCeG8n5xeR5VQ49FZwgG7witBBDXP9rJiw6tgVNNilCS+ar21SwO/rEwejSFwy7 CG6y1NWghlQccW3xJz+OtW0Sh; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:34416 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wPiQN-000000043Ax-0p2J; Wed, 20 May 2026 09:01:31 -0600 From: Tom Tromey To: Abdul Basit Ijaz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/1] gdb: Handle TYPE_CODE_COMPLEX in valprint_check_validity. In-Reply-To: <20260520090701.12057-1-abdul.b.ijaz@intel.com> (Abdul Basit Ijaz's message of "Wed, 20 May 2026 11:07:01 +0200") References: <20260520090701.12057-1-abdul.b.ijaz@intel.com> X-Attribution: Tom Date: Wed, 20 May 2026 09:01:29 -0600 Message-ID: <878q9eazw6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wPiQN-000000043Ax-0p2J X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:34416 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJe7GSnE2RTM4X7bkksrvCN13pffNCDuMhvc5cZ6JesjZkqSoi7hyW2QASyCDZOC8whHOf8UJbmvTAGgXnef7xKGWvMsDnO7CUuEdogAQViINOlfmwmk mO6KKvSliofZ9z2Ny4mFf8tcEc0Ky94hvlL9B1niYphHvYhSRpMucbc+TUGBV7HAVu6KwdZGnwp/zClulBTs0X99ejE/rYPnQGs= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Abdul Basit Ijaz writes: > The issue occurred because valprint_check_validity () only exempted > TYPE_CODE_UNION, TYPE_CODE_STRUCT, and TYPE_CODE_ARRAY from the > optimized-out check, but not TYPE_CODE_COMPLEX. Complex types, like > structures, can have components with different availability. Thanks for the patch. I wouldn't be surprised if there are other places that check for "aggregate" types and overlook the complex number case. > + DW_OP_implicit_value 0x00 0x00 0x40 0x40 I guess it's possible that this will be something strange on some system, one with a weird floating point encoding. However I think it's fine not to worry about it for now. > +gdb_test "print z1" "= \[0-9\]+ \\+ i" \ Just as an aside, this is the kind of thing that quotemeta makes nicer, like [quotemeta " = @DECIMAL + i"] But anyway what you have is also fine. Approved-By: Tom Tromey Tom