From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lw31MrJYF2o8GCEAWB0awg (envelope-from ) for ; Wed, 27 May 2026 16:48:50 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=SzNrT5UR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BC48E1E0A3; Wed, 27 May 2026 16:48:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C08BD1E024 for ; Wed, 27 May 2026 16:48:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 71A9B4BA23E9 for ; Wed, 27 May 2026 20:48:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71A9B4BA23E9 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=SzNrT5UR Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id E52524BA23DF for ; Wed, 27 May 2026 20:48:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E52524BA23DF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E52524BA23DF Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779914887; cv=none; b=OzN/TiDnCjd8YVzaDHqP8WESZ2WspT/6iVV0dEvUwf/LEGgROS5PT11RvA3AlHsO9Pov09OaR+kVDQeAbMiju1ejST4dsvz8wHHMmhmE5so+9pcqtl0EXfcYV36BA72K0vbHHjvMGHwmOdS6lvNpYaI7KG8Ij7AcoePm54xbDj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779914887; c=relaxed/simple; bh=4yYH8fCzwGGgNlDAiBXQT9LpX6gRAmIBLSDKe64XkoQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BpjNvtW7rRLqp32OSmsjXGC4FjcovdNMjZO/SXpvcRTlnf+2sa9HldVDNvExO0dR1uk36GHit/eVN2ZHNO+4ilm6U1fcmJ7BOxGEFpRjTsACaWXDoZrlNFj0IpZ24JkERWKSsDus3Sd7JTUpJmph2n8jPliCGyOi6SY5nYZ/Fmg= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=SzNrT5UR reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E52524BA23DF Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id S6N9w8QWhgwLnSLAcwcqCN; Wed, 27 May 2026 20:48:06 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id SLAbwfyIkTzOdSLAcwi5i8; Wed, 27 May 2026 20:48:06 +0000 X-Authority-Analysis: v=2.4 cv=FbE3xI+6 c=1 sm=1 tr=0 ts=6a175886 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=4EQSq1cwqb157ImfWYoA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Bt41LLcMJRsnpYQ1jh4a+/paaH1q4U06xGUy10cNpmU=; b=SzNrT5URl9M0+t7omx40kPhw7z y6g6lyxvUrYPc8HEtLZ28d0BpVeJOz6KbhRH/Y6sJlNkzexQX3CkSGMUAyD26ZAmo/3CmdqhCcgyR dQHy5itV4d7REnzjX5mPbVftq; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:48800 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wSLAb-000000014eG-2cwc; Wed, 27 May 2026 14:48:05 -0600 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/2] [gdb/symtab] Fix data race in try_open_dwop_file In-Reply-To: (Tom de Vries's message of "Wed, 27 May 2026 21:16:16 +0200") References: <20260216180925.3174052-1-tdevries@suse.de> <20260216180925.3174052-3-tdevries@suse.de> <877brrnxrw.fsf@tromey.com> X-Attribution: Tom Date: Wed, 27 May 2026 14:48:04 -0600 Message-ID: <878q947f5n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wSLAb-000000014eG-2cwc X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:48800 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGjLkl0sVbrNGIsz4LdtmDzwK4RmT2/Eg1feSB1xDlA/BTsABPcE4DZcy6cqO984ej80S7asMgsWs+OtW3iBF/Y2qhekQOj+3rU1apfGUDBkYbFwBHBY ulWSRkn4/OjBNdkwvZGDrvhBcZTI2do1SbuZjUcRWF4OAk2Y5kMiSh6kpwVuXsbHvA9qy2/Kru+LGz4pOG/e82qHa6gIJNfZUfQ= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> AFAIU, bfd_check_format does locking, but it's only used to [1]: Tom> ... Tom> lock the internal global data structures of BFD (like its global cache Tom> or some global counter), but not data in individual `bfd *`instances. Tom> ... Tom> So while it does do locking, it's not sufficient. How so? I mean, since it's a recursive lock, it's not like locking it some more can cause a problem. But at the same time I don't think it adds any more protection. Tom