From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mFeEM6+jGWqPFScAWB0awg (envelope-from ) for ; Fri, 29 May 2026 10:33:19 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pDsQKJb4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BE9EF1E0A3; Fri, 29 May 2026 10:33:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 270791E062 for ; Fri, 29 May 2026 10:33:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A97064BA23DA for ; Fri, 29 May 2026 14:33:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A97064BA23DA Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pDsQKJb4 Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 8017D4BA2E05 for ; Fri, 29 May 2026 14:32:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8017D4BA2E05 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8017D4BA2E05 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780065171; cv=none; b=jV0Mt7uPGooT7flQ+WwRNUrDhmrpNXDWYoGCg9ssyqXa4QIAZjnfrMhQSCrVknZ/1QYXGWidFQBop+Pjb86BXIZv/GmDAYT9XTUxGy7/EpuWl/ZA8OYSylJFU33HJUmqNxZ29S6DidScpBw4RmZqDX6g097wZtH3idkzSl3dL50= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780065171; c=relaxed/simple; bh=bjN99WBxo+MTqlRt06QHgW4wjqmNogDOY9bxp8kAlzU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=NsciCrKkHJRSc3tQkXoYQsupiCQz6rtDNhX3bZAn8FfaL/2mvVjfhyIFKM/ozis8A+OhjmKa3udWPLIUttuw9aMUFR38rgQlYYpaRPQGvLr1tLTB9VE4MaOeB8I8RKBUfoSR7LP9sj7vNVun9aL2VmmX+R7xeQEsgGYFLPGJUng= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pDsQKJb4 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8017D4BA2E05 Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id Sy7IwrWtflPo5SyGYwb6ns; Fri, 29 May 2026 14:32:50 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id SyGWwDYDnWBahSyGXwQ78X; Fri, 29 May 2026 14:32:49 +0000 X-Authority-Analysis: v=2.4 cv=Y9D4sgeN c=1 sm=1 tr=0 ts=6a19a391 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=chNEMbGMAoGGUO-slWsA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xflD46exkj6dIzlwbQtTIJibbDZ48ZbKV3vPhEKXyxU=; b=pDsQKJb400C5PKgcB7EyxlNQi+ G3WcCPSK6VZ8uHHbME+QFzx24pJXdz4wsLYCQqlxSeozLiglKCNZSYuA6jhN90SPqiHVocu6DKkdr mx32tTgF4hszAC32/evPa5ctl; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:34628 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wSyGW-00000002uIT-2T9E; Fri, 29 May 2026 08:32:48 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/python: avoid switching threads for send_packet where possible In-Reply-To: (Andrew Burgess's message of "Tue, 26 May 2026 16:50:12 +0100") References: X-Attribution: Tom Date: Fri, 29 May 2026 08:32:47 -0600 Message-ID: <878q925lrk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wSyGW-00000002uIT-2T9E X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:34628 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDukqjrChjv/p3jdwvKQiSIyaKOEHj0R3az4G4nCx+A0JUBUmQm64tfkMowow2lPY9PUqEOHqLHWDkaoFrQDzLd0fMDTF9MFm+4QiIklzxhARS2qNbew hRjwWcL/AFXOPjUU6tx0GUTpsZOhz6qDWa4608RNG/MRJEBJlGGTD2Vi+TmrlnedFGjYV7tBprqeMlnFUDil0lVSypac/tVRtms= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> Bug PR gdb/32120 identifies a case where a user tried to write a Andrew> custom frame unwinder that made use of Andrew> RemoteTargetConnection.send_packet Just for the record this seems like a weird and bad choice. Andrew> scoped_restore_current_thread restore_thread; Andrew> switch_to_target_no_thread (conn->target); Andrew> The purpose of this is to ensure that the currently selected inferior Andrew> has the required remote connection pushed on its target stack. This Andrew> is necessary because `send_remote_packet` (see remote.c) still relies Andrew> on global state read from the currently selected inferior. Andrew> Switching inferior and thread like this, and then switching back Andrew> thanks to the scoped restore, will flush the frame cache. ... Andrew> I propose that we special case connpy_send_packet so if the correct Andrew> inferior is already current then we avoid the switch completely. This Andrew> avoids flushing the frame cache, and all the associated problems. No problem with the patch at all, but I wonder about the logic of putting this check here and not elsewhere. Like would we want some sort of "switch to this inferior and we don't care which thread" -- which would be a no-op if the inferior is already selected? Tom