Re: [PATCH] [gdb] Remove gdb-gdb.gdb dependency in make all rule

[Andrew Burgess <aburgess@redhat.com>]

Tom de Vries <tdevries@suse.de> writes:

> In gdb/Makefile.in we have:
> ...
> all: gdb$(EXEEXT) $(CONFIG_ALL) gdb-gdb.gdb gcore gstack gdb-add-index
> ...
>
> The dependency on gdb-gdb.gdb made sense before commit ffeb311d2cd
> ("[gdb/build] Rename gdb/gdb-gdb.gdb.in to gdb/gdb-gdb.gdb"), but now we
> use AC_CONFIG_LINKS and there's no longer a corresponding make rule.
>
> Remove gdb-gdb.gdb from the dependency list.

Makes sense.

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew


> ---
>  gdb/Makefile.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 767f9280864..d8db6eecf0f 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -2088,7 +2088,7 @@ generated_files = \
>  # Flags needed to compile Python code
>  PYTHON_CFLAGS = @PYTHON_CFLAGS@
>  
> -all: gdb$(EXEEXT) $(CONFIG_ALL) gdb-gdb.gdb gcore gstack gdb-add-index
> +all: gdb$(EXEEXT) $(CONFIG_ALL) gcore gstack gdb-add-index
>  	@$(MAKE) $(FLAGS_TO_PASS) DO=all "DODIRS=$(SUBDIRS)" subdir_do
>  
>  # Rule for compiling .c files.
>
> base-commit: 32090b27e92cb8fd4998e8e8e65d43f445545bc7
> -- 
> 2.51.0