From: Tom Tromey <tom@tromey.com>
To: Jan Vrany <jan@vrany.io>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Convert py-connection.c to the Python safety API
Date: Tue, 22 Sep 2026 15:16:09 -0600 [thread overview]
Message-ID: <878q4t56na.fsf@tromey.com> (raw)
In-Reply-To: <db20b84105cfa66d9019db593ef88c5f458d44b0.camel@vrany.io> (Jan Vrany's message of "Mon, 21 Sep 2026 13:29:53 +0000")
>> + /* Require that this object be valid. */
>> + void require () const;
>> +
Jan> I think it'd be nice to have consistent naming (and maybe even implementation).
Jan> In py-symbol.c and py-tui.c it is "require_valid".
Makes sense. I did this locally.
Jan> Perhaps even the implementation can be unified to use is_valid() instead of
Jan> nullptr test?
I did this too.
Tom
prev parent reply other threads:[~2026-09-22 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 18:07 Tom Tromey
2026-09-21 13:29 ` Jan Vrany
2026-09-22 21:16 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878q4t56na.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=jan@vrany.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox