From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6XS+NEnjumot7hMAWB0awg (envelope-from ) for ; Mon, 28 Sep 2026 17:59:37 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=c7HIRjQu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D17B31E01F; Mon, 28 Sep 2026 17:59:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2C9201E01F for ; Mon, 28 Sep 2026 17:59:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B40644B99F4F for ; Mon, 28 Sep 2026 21:59:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B40644B99F4F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=c7HIRjQu Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 18E164BAE7CE for ; Mon, 28 Sep 2026 21:59:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18E164BAE7CE Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 18E164BAE7CE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790632752; cv=none; b=p2RDJdyi/RcGwhzwwBTIvGIfCR6LnGCGE1pa4shCWPw794OJ1gbExiqbCvk1k/AuGSoem+mquFeyiffmjQU2il3T6r0AK5lzwuhhvc7LwWvusDzfKwkGVYpoKz/xB+6q+wnCd/LJnevMdDOSfELEhoN6hLAzqabY54sxI+2yVnM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790632752; c=relaxed/simple; bh=qVnypRMgUhNW54+K7FsM3FvplxXnyIiSnnU902/iQLQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ah7fZngZFPu0PI1tsfd6UCTeTbL0ux+nDATRX+Q2/04k5jmmz1pr4hWKeUZ8WaGHG9DQx4C3T5etfsTHPS3W3UvcEq3YCtyY2iNGs/x4zmxXSR+hr4LO0DqxKFmn4Y2gCY4pqD8oOe9dz78gUdgedznAlzEZA7z4UBPi1yGm1Y0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=c7HIRjQu DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 18E164BAE7CE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790632751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+EgM3uv5YejBXpqlMfan8hCNNWKyLKWV8NB4jhxeKOI=; b=c7HIRjQugHePA0aMyQAs69I/tpd7gqZMLHUtqGNMrB7zBhmM5xZpmjpRJ/q17Vd4q3nu7E fAKD3DB2xX4uIUkkgwNH6Mv72jGRb87TA2UrAvrw876lwBok4u0atA8Xm42LYi6Lr/L3VU Md2EeW69AESQ5tx8epTVxDgRi0wApE8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-7gXZxs_UOtWRC6egkkXGuQ-1; Mon, 28 Sep 2026 17:59:10 -0400 X-MC-Unique: 7gXZxs_UOtWRC6egkkXGuQ-1 X-Mimecast-MFC-AGG-ID: 7gXZxs_UOtWRC6egkkXGuQ_1790632749 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49cdc4080ddso729695e9.1 for ; Mon, 28 Sep 2026 14:59:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790632749; x=1791237549; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=+EgM3uv5YejBXpqlMfan8hCNNWKyLKWV8NB4jhxeKOI=; b=ZQq9mgtgkA9lmU8uHxpMXKjX4MP0DGv8+gsgkjqtWpUJ4X3DPVa3Jrn6K8R8/hcDLy G1ZQSZ9ErGyFKd1DBQUJ6Yo60y7xt9TSiXQN43N71jkUMGEaHzuPzBmQyX9N50olwtyP 3jjM6krj+2jynGAIPzoH+4Q4FJ0kF3MxHASOTXTnEVS6TIsJinftZN14vmf75KEuWmRU DNz1lmP243YC7fZPKscIsGOC71rbq3bFnVybsKbhlvmqe3z6K+4pHPr74izmyrQtLJOQ BZQPj2ZtKLBL+o4TqRpP+ADoNCZs94VHEzQgHl+NCgGGYK6qSfT+AmWkFpcK6kwq4+9h 5YkA== X-Forwarded-Encrypted: i=1; AKwUvBzAcrdQGsCX4oNw5IjAiPumQIhrxi0D76pTabH9OubhW+lsnUuNS1enAf+uVCAQ4lhItt5dRU9LBOBPKw==@sourceware.org X-Gm-Message-State: AFuF++m+Kjz0aS1nh4mY5EE7CLQVhXnjDUSYzIpA/atDQTaT59qE/D6v 7KXMZwCWhw6pEyiLvcNfeylxf4OEWgx2JJoXAZHb0OdsmnyNQj7EpdDRIWwv0NiM+mWoWrEUvXb SyYNX8BuWdKI7MQUc62Bo0p6w6fnYPLEDMA00CiBiZlP/FTO5FmUsNs1Xb6sjRQsPZX9iMq8= X-Gm-Gg: AYBFou2NHoyG5bTogwAQIBFFGRzAX6TbZilynAU2aUu1JGPE3rFhLToMycb0RKfe9cN vHfXvQXOMW/YqXz3WJzDCzI8sbAvnI8xeffqZfN4Etf5FB+EzHC9+LSID8tn38k0CxEATu11aro ELvCNgR/iof+cO8DpOOyKBEzp1RKF0EGONvqJQ3Q19pWZe/6hOt1TWYZX54KXkljG6BW047PkNn 4zCRis2hlBhCWucajDHbJOmN9Sxd7RbIdVz+LTOceEJzzskDCJ9VAcPgRdBJXmLZSalck8w1ulq L0xf4fddHTELV7KfaEGALZLQeaK5iplLMPoGk9V9zQtdeTUz2NF5JIOYeN0sBmCkHjsd X-Received: by 2002:a05:600c:4e41:b0:49e:715d:95ca with SMTP id 5b1f17b1804b1-4a00d778ed3mr8765215e9.13.1790632749112; Mon, 28 Sep 2026 14:59:09 -0700 (PDT) X-Received: by 2002:a05:600c:4e41:b0:49e:715d:95ca with SMTP id 5b1f17b1804b1-4a00d778ed3mr8765005e9.13.1790632748735; Mon, 28 Sep 2026 14:59:08 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a00cf2d973sm29119585e9.0.2026.09.28.14.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 14:59:07 -0700 (PDT) From: Andrew Burgess To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH] gdb: fix nan in scoped_time_it output In-Reply-To: <20260928181855.3217561-1-simon.marchi@polymtl.ca> References: <20260928181855.3217561-1-simon.marchi@polymtl.ca> Date: Mon, 28 Sep 2026 22:59:05 +0100 Message-ID: <878q4l11hy.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -ozM8TeotTvEXuD9pbY2bEhE064Puy2ec15ZSk9RBEU_1790632749 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org simon.marchi@polymtl.ca writes: > From: Simon Marchi > > With "maintenance set per-command time on", a scope that takes less > than a millisecond prints: > > Time for "...": wall 0.000, user 0.000, sys 0.000, user+sys 0.000, -nan % CPU > > The durations are converted to an integer millisecond count before the > CPU usage is computed, so a sub-millisecond scope truncates the wall > time to zero, and the division produces a NaN (or an infinity, if the > CPU time is not zero). We don't really care about sub-millisecond > durations for the purpose of this tool, so just add a check for > `wall_ms == 0`, and report the CPU usage as 0% if true. This is purely > cosmetic. LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: Iaf682bef4b537d6dbb58e82f7727c0ea079088aa > --- > gdb/maint.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gdb/maint.c b/gdb/maint.c > index 8027429e6d39..22954f624efe 100644 > --- a/gdb/maint.c > +++ b/gdb/maint.c > @@ -1230,7 +1230,8 @@ scoped_time_it::~scoped_time_it () > "user+sys %.03f, %.01f %% CPU\n", > m_what, wall_ms / 1000.0, user_ms / 1000.0, > sys_ms / 1000.0, user_plus_sys_ms / 1000.0, > - user_plus_sys_ms * 100.0 / wall_ms); > + (wall_ms == 0 > + ? 0.0 : user_plus_sys_ms * 100.0 / wall_ms)); > gdb_stdlog->write_async_safe (str.data (), str.size ()); > } > > > base-commit: 421bec796fa3a06179856da870a13cf71ddf5df2 > -- > 2.55.0