From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8198 invoked by alias); 7 Oct 2007 18:41:22 -0000 Received: (qmail 8190 invoked by uid 22791); 7 Oct 2007 18:41:22 -0000 X-Spam-Check-By: sourceware.org Received: from smtp.nildram.co.uk (HELO smtp.nildram.co.uk) (195.112.4.54) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 07 Oct 2007 18:41:17 +0000 Received: from firetop.home (85-211-25-104.dyn.gotadsl.co.uk [85.211.25.104]) by smtp.nildram.co.uk (Postfix) with ESMTP id DAD942C9F76 for ; Sun, 7 Oct 2007 19:40:59 +0100 (BST) Received: from richard by firetop.home with local (Exim 4.63) (envelope-from ) id 1Ieb3m-0005ni-WC for gdb-patches@sourceware.org; Sun, 07 Oct 2007 19:41:03 +0100 From: Richard Sandiford To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org, rsandifo@nildram.co.uk Subject: Re: [patch] Fix ll, sc and swxc1 for the 32-bit MIPS simulator References: <87k5q5v5pg.fsf@firetop.home> <20071007044307.GA20114@caradoc.them.org> Date: Sun, 07 Oct 2007 18:41:00 -0000 In-Reply-To: <20071007044307.GA20114@caradoc.them.org> (Daniel Jacobowitz's message of "Sun\, 7 Oct 2007 00\:43\:07 -0400") Message-ID: <877ily7oox.fsf@firetop.home> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00101.txt.bz2 Daniel Jacobowitz writes: > On Tue, Oct 02, 2007 at 05:31:23PM +0100, Richard Sandiford wrote: >> mips.igen's handling of ll, sc and swxc1 is currently hardwired >> for WITH_TARGET_WORD_BITSIZE == 64. The patch below fixes this >> by using the same constructs as other loads and stores. It cures >> gcc.target/mips/atomic-memory-1.c for mipsisa32-elf and introduces >> no regressions. OK to install? >> >> Richard >> >> >> sim/mips/ >> * mips.igen (ll): Fix mask for WITH_TARGET_WORD_BITSIZE == 32. >> (sc, swxc1): Likewise. Also fix big-endian and reverse-endian >> shifts for that case. > > OK, thanks. Thanks, installed.