From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15008 invoked by alias); 21 Feb 2012 20:59:24 -0000 Received: (qmail 15000 invoked by uid 22791); 21 Feb 2012 20:59:23 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Feb 2012 20:59:06 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1LKx6MZ003575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Feb 2012 15:59:06 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1LKx56q019155; Tue, 21 Feb 2012 15:59:05 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q1LKx4La010884; Tue, 21 Feb 2012 15:59:04 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com Subject: Re: testsuite: prefix handling References: <20120217193546.10029.74207.stgit@hit-nxdomain.opendns.com> <20120217193648.10029.26589.stgit@hit-nxdomain.opendns.com> <87pqdd9pjs.fsf@fleche.redhat.com> <4F3EBEAC.1070805@redhat.com> <87k43l87vb.fsf@fleche.redhat.com> <4F43B6A5.3010900@redhat.com> <87wr7gt63r.fsf@fleche.redhat.com> <4F43E459.9070706@redhat.com> Date: Tue, 21 Feb 2012 21:00:00 -0000 In-Reply-To: <4F43E459.9070706@redhat.com> (Pedro Alves's message of "Tue, 21 Feb 2012 18:37:13 +0000") Message-ID: <877gzfsy1z.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00453.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I really dislike mixing in a lot of formatting changes with Pedro> code changes, so I was really avoiding it. Yeah, I totally blanked out about that. I completely agree. Pedro> Honestly, I kind of liked the current formatting -- I was kind of Pedro> reading it as a function attribute. But I don't mind seeing this Pedro> re-indented either. But that's a lower priority to me. If you don't object I will do it. There's also the defining style (untested): proc prefix_proc {name arglist substitution body} { set delayed "\[[list subst $substitution]\]" proc $name $arglist [list with_test_prefix $delayed $body] } prefix_proc test_something {name} {hi: $name} { blah blah } Ok, I wouldn't really want to use it anyway... Tom