From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3337 invoked by alias); 26 Mar 2012 19:31:28 -0000 Received: (qmail 3328 invoked by uid 22791); 26 Mar 2012 19:31:27 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Mar 2012 19:31:06 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2QJV5L8025771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Mar 2012 15:31:05 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q2QJV4DJ013000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 26 Mar 2012 15:31:05 -0400 From: Tom Tromey To: Keith Seitz Cc: "gdb-patches\@sourceware.org ml" Subject: Re: [RFA 1/3] Linespec rewrite: Parsing References: <4F67A319.4090608@redhat.com> Date: Mon, 26 Mar 2012 19:31:00 -0000 In-Reply-To: <4F67A319.4090608@redhat.com> (Keith Seitz's message of "Mon, 19 Mar 2012 14:20:25 -0700") Message-ID: <877gy788hz.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00885.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> +/* A convenience macro for trimming trailing whitespace Keith> + from string P. */ We have remove_trailing_whitespace now, see cli-utils.h. Keith> + *(_p + 1) = '\0'; \ I'm curious if this is writing into temporary strings or into the input string. I ask because I think the module would generally be friendlier if it were const-correct and did not write into the input strings. This would make its behavior more predictable. However I didn't audit it to see whether this is reasonably practical; and the language parsers may throw a wrench into this idea. I only skimmed the rest, since: Keith> I have pushed a patch to my archer branch which permits Keith> quote-encapsulating the linespec. I have also reverted the Keith> "invalid" linespec tests. ... I think it is time to send fresh patches. Tom