From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23235 invoked by alias); 23 Jul 2012 14:49:53 -0000 Received: (qmail 23223 invoked by uid 22791); 23 Jul 2012 14:49:51 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jul 2012 14:49:33 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6NEnXM0030911 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Jul 2012 10:49:33 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6NEnWw3013148 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 23 Jul 2012 10:49:33 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 01/10] change gdb to refcount bfd everywhere References: <87vchk3lxs.fsf@fleche.redhat.com> <20120719141750.GB23801@host2.jankratochvil.net> <877gtzxyck.fsf@fleche.redhat.com> <20120722190009.GA25479@host2.jankratochvil.net> Date: Mon, 23 Jul 2012 14:49:00 -0000 In-Reply-To: <20120722190009.GA25479@host2.jankratochvil.net> (Jan Kratochvil's message of "Sun, 22 Jul 2012 21:00:09 +0200") Message-ID: <877gtusfb7.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00447.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> There was some conclusion on gdb-patches to make happy both people Jan> wanting comments in *.c and people wanting comments in *.h and to Jan> prevent duplication of the same comment in both *.c and *.h which Jan> leads to stale invalid comments in one of the files to put the Jan> comment only in *.h file and in the *.c file state: /* See Jan> gdb_bfd.h. */ You even use it at various functions in gdb_bfd.c, Jan> just not for gdb_bfd_ref and gdb_bfd_unref. I'll fix it. Tom> I wonder if I should rename it to gdb_bfd_open_maybe_remote, for Tom> consistency. What do you think? I'm inclined to do it. Jan> Definitely. I'll do this shortly. Tom