From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14000 invoked by alias); 27 Sep 2012 20:58:59 -0000 Received: (qmail 13991 invoked by uid 22791); 27 Sep 2012 20:58:58 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Sep 2012 20:58:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8RKwloJ009205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 27 Sep 2012 16:58:48 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8RKwkKJ019993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 27 Sep 2012 16:58:46 -0400 From: Tom Tromey To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects. References: <1348462325-4891-1-git-send-email-sanjoy@playingwithpointers.com> <1348462325-4891-3-git-send-email-sanjoy@playingwithpointers.com> Date: Thu, 27 Sep 2012 20:58:00 -0000 In-Reply-To: <1348462325-4891-3-git-send-email-sanjoy@playingwithpointers.com> (Sanjoy Das's message of "Mon, 24 Sep 2012 10:22:04 +0530") Message-ID: <877grfuqrd.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00644.txt.bz2 >>>>> "Sanjoy" == Sanjoy Das writes: Sanjoy> + if (IS_ABSOLUTE_PATH(args)) Missing a space before the open paren. This one is ok with that change. Tom