From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21112 invoked by alias); 10 Sep 2014 16:11:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21102 invoked by uid 89); 10 Sep 2014 16:11:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Sep 2014 16:11:36 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8AGBT5K031375 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Sep 2014 12:11:29 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8AGBSos004738 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 10 Sep 2014 12:11:29 -0400 From: Sergio Durigan Junior To: Joel Brobecker Cc: Gabriel Krisman Bertazi , gdb-patches@sourceware.org Subject: Re: [PING] [PATCH] Fix gdb.fortran/array-element.exp failures. References: <8761jbbu6l.fsf@Argo.krisman.be> <87lhrv36pm.fsf@Argo.krisman.be> <87zjf3sqrd.fsf@krisman.be> <87r4048546.fsf_-_@krisman.be> <20140909130901.GG28404@adacore.com> <87d2b4c07h.fsf@anubis.Home> <20140909154531.GJ28404@adacore.com> <87ppf4acb5.fsf@anubis.Home> <20140910125037.GN28404@adacore.com> X-URL: http://www.redhat.com Date: Wed, 10 Sep 2014 16:11:00 -0000 In-Reply-To: <20140910125037.GN28404@adacore.com> (Joel Brobecker's message of "Wed, 10 Sep 2014 05:50:37 -0700") Message-ID: <877g1blakv.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00332.txt.bz2 On Wednesday, September 10 2014, Joel Brobecker wrote: > My only comment is that simplications are indeed good, but it is > better if you can submit those separately from other changes. > It's easier to review the patch series that way, and it also > allows us separate the real change from the enhancement which > is expected to be a no-op. Mea culpa. I thought it would be nice to simplify the testcase in one shot, because it seemed to me that the error happened *also* because the testcase was not very clear. And since I had applied the patch, investigated and figured out that it did the right thing, I thought it'd be good to simplify it too. Sorry if it made the review harder! -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/