From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15961 invoked by alias); 12 Sep 2014 03:20:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15951 invoked by uid 89); 12 Sep 2014 03:20:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Sep 2014 03:19:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8C3Jqf8003328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 11 Sep 2014 23:19:53 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8C3Jq8I013311 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 11 Sep 2014 23:19:52 -0400 From: Sergio Durigan Junior To: Edjunior Barbosa Machado Cc: gdb-patches@sourceware.org, Ulrich Weigand Subject: Re: [PATCH] [PR tdep/17379] Fix internal-error when stack pointer is invalid References: <1410490007-19756-1-git-send-email-emachado@linux.vnet.ibm.com> X-URL: http://www.redhat.com Date: Fri, 12 Sep 2014 03:20:00 -0000 In-Reply-To: <1410490007-19756-1-git-send-email-emachado@linux.vnet.ibm.com> (Edjunior Barbosa Machado's message of "Thu, 11 Sep 2014 23:46:47 -0300") Message-ID: <877g195xuv.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00380.txt.bz2 On Thursday, September 11 2014, Edjunior Barbosa Machado wrote: > Thanks Sergio for your feedback. I'm resending the patch with an additional > testcase as you suggested. Nice, thanks :-). > diff --git a/gdb/testsuite/gdb.arch/powerpc-stackless.exp b/gdb/testsuite/gdb.arch/powerpc-stackless.exp > new file mode 100644 > index 0000000..f4b2a90 [...] > +standard_testfile powerpc-stackless.S Just another really minor nit, no need to resubmit the patch because of this. You can write: standard_testfile .S Other than that, it is perfect. Thanks a lot! -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/