Re: [PATCH 3/5] ARM: arm_breakpoint should be little endian form in case for arm BE8

Yao Qi
2014-10-21T08:13:57Z

Victor Kamensky <victor.kamensky@linaro.org> writes:

> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 2aef5dc..c32fb3f 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,10 @@
> 2014-10-13 Victor Kamensky <victor.kamensky@linaro.org>
>
> + * arm-tdep.c: (extract_arm_insn): use dbarch_byte_order_for_code
> + to read arm instruction.

The file and function name in the changelog entry is wrong. The
description of each entry is a sentence, so the first letter should be
capitalized.

* arm-linux-tdep.c (arm_linux_init_abi): Use
gdbarch_byte_order_for_code to read arm instruction.

Otherwise, it looks good to me.

--
Yao (齐尧)