Re: [PATCH 0/5] arm: set of big endian related fixes for armeb (v7)

Andrew Pinski
2014-10-21T01:12:58Z

On Mon, Oct 20, 2014 at 5:56 PM, Victor Kamensky
<victor.kamensky@linaro.org> wrote:
> Hi Folks,
>
> Please find five patches following this cover letter that address several
> big endian related issues for ARM V7 target. Problems were discovered by
> running gdb/testsuite on armeb (big endian) target rootfs/kernel and
> comparing results from the same source against arm (little endian).
>
> Note there are several failures remain that are not addressed by this
> series. I.e valgrind related test cases all failed, because valgrind does
> not support armeb target. There are other failures in a bit obscure
> places like gdb.dwarf2/implptrpiece.exp, gdb.python/py-value-cc.exp,
> but over all number of passes/failures significantly improved in armeb
> case.
>
> Please note it is my first attempt to contribute into gdb. If I missed
> something please guide me how I can correct that.

Yes bfd patches need to be also sent to binutils@.

Thanks,
Andrew Pinski

>
> Thanks,
> Victor
>
> Victor Kamensky (5):
> ARM: plt_size functions need to read instructions in right byte order
> ARM: extract_arm_insn function need to read instrs correctly in be8
> case
> ARM: arm_breakpoint should be little endian form in case for arm BE8
> ARM: read_pieced_value do big endian processing only in case of valid
> gdb_regnum
> ARM: asm-source.exp link options in case of armv7b target
>
> bfd/ChangeLog | 9 +++++++
> bfd/elf32-arm.c | 48 +++++++++++++++++++++++++++++++++---
> gdb/ChangeLog | 16 ++++++++++++
> gdb/arm-linux-tdep.c | 2 +-
> gdb/arm-tdep.c | 2 +-
> gdb/dwarf2loc.c | 30 +++++++++++-----------
> gdb/testsuite/ChangeLog | 4 +++
> gdb/testsuite/gdb.asm/asm-source.exp | 4 +++
> 8 files changed, 94 insertions(+), 21 deletions(-)
>
> --
> 1.8.1.4
>