From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17025 invoked by alias); 21 Nov 2014 13:22:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17013 invoked by uid 89); 21 Nov 2014 13:22:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Nov 2014 13:22:10 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XroA2-0005Qz-PR from Yao_Qi@mentor.com ; Fri, 21 Nov 2014 05:22:06 -0800 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.181.6; Fri, 21 Nov 2014 05:22:06 -0800 From: Yao Qi To: Pedro Alves CC: Subject: Re: [PATCH 6/7] Include wchar.h and wctype.h unconditionally References: <1416057612-16155-1-git-send-email-yao@codesourcery.com> <1416057612-16155-7-git-send-email-yao@codesourcery.com> <546F34BA.20809@redhat.com> Date: Fri, 21 Nov 2014 13:22:00 -0000 In-Reply-To: <546F34BA.20809@redhat.com> (Pedro Alves's message of "Fri, 21 Nov 2014 12:48:58 +0000") Message-ID: <877fyog03a.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00516.txt.bz2 Pedro Alves writes: > It's hard to reason about all the modes supported here, but > I think this is OK. Seems like the comment above about wchar_t > support should be updated though. > At the beginning, I tried to change more than what I did in this patch, but I got myself in trouble in these different modes, which I don't fully understand. I'll revisit it once my gnulib patches queue is empty. > (I wonder whether if we pulled in the gnulib btowc module, we could > get rid of at least some of this fallback stuff. We're already > pulling in mbrtowc...) Agreed, that is one thing we could do. --=20 Yao (=E9=BD=90=E5=B0=A7)