From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72385 invoked by alias); 11 Nov 2016 03:19:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72361 invoked by uid 89); 11 Nov 2016 03:19:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=HTo:U*palves X-HELO: gproxy1.mail.unifiedlayer.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO gproxy1.mail.unifiedlayer.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Nov 2016 03:19:54 +0000 Received: from cmgw3 (cmgw4 [10.0.90.84]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id B4B8D1778AE for ; Thu, 10 Nov 2016 20:17:14 -0700 (MST) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id 6THB1u00f2f2jeq01THEXb; Thu, 10 Nov 2016 20:17:14 -0700 X-Authority-Analysis: v=2.1 cv=WL/sABcR c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=L24OOQBejmoA:10 a=20KFwNOVAAAA:8 a=WOoI3icCOHWEoaRCIDMA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:54364 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1c52L1-0001a7-CS; Thu, 10 Nov 2016 20:17:11 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 16/20] Use gdbpy_enter in gdbpy_get_matching_xmethod_workers References: <1478816387-27064-1-git-send-email-tom@tromey.com> <1478816387-27064-17-git-send-email-tom@tromey.com> <8356ffb0-722d-c6fb-c063-e18c24b3ccab@redhat.com> Date: Fri, 11 Nov 2016 03:19:00 -0000 In-Reply-To: <8356ffb0-722d-c6fb-c063-e18c24b3ccab@redhat.com> (Pedro Alves's message of "Thu, 10 Nov 2016 23:19:46 +0000") Message-ID: <877f8ak8ne.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1c52L1-0001a7-CS X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya) [174.16.143.211]:54364 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-11/txt/msg00282.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> - Py_DECREF (temp); >> - Py_DECREF (pspace_matchers); Pedro> I'm a little confused here. Don't we still need to account for Pedro> these two Py_DECREFs? The patch reads a little messily. The new code is: gdbpy_reference pspace_matchers (pspy_get_xmethods (py_progspace, NULL)); gdbpy_reference temp (PySequence_Concat (py_xmethod_matcher_list.get (), pspace_matchers.get ())); if (temp == NULL) { gdbpy_print_stack (); return EXT_LANG_RC_ERROR; } py_xmethod_matcher_list = temp; So the decrefs are accounted for by the destructors; and that assignment at the end encodes an incref via the copy constructor. Moving here would have been a valid choice as well, like: py_xmethod_matcher_list = std::move (temp); ... though I deleted the move constructor since it wasn't used in the earlier series and Jan pointed out that it had a bug. Tom