From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91676 invoked by alias); 12 Apr 2017 14:31:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91183 invoked by uid 89); 12 Apr 2017 14:31:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:267 X-HELO: gproxy9.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 14:31:51 +0000 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id 7DC361E10CD for ; Wed, 12 Apr 2017 08:31:50 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id 7SXn1v0082f2jeq01SXqZY; Wed, 12 Apr 2017 08:31:50 -0600 X-Authority-Analysis: v=2.2 cv=VKStp5HX c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=20KFwNOVAAAA:8 a=Mao01aE-p6CRXMlpHz4A:9 a=_RM7nvDVKvkA:10 Received: from 75-166-65-226.hlrn.qwest.net ([75.166.65.226]:56278 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cyJJC-0006O8-VX; Wed, 12 Apr 2017 08:31:47 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 05/17] Change increment_reading_symtab to return a scoped_restore References: <20170411150112.23207-1-tom@tromey.com> <20170411150112.23207-6-tom@tromey.com> Date: Wed, 12 Apr 2017 14:31:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 12 Apr 2017 12:16:17 +0100") Message-ID: <877f2p7l4g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cyJJC-0006O8-VX X-Source-Sender: 75-166-65-226.hlrn.qwest.net (bapiya) [75.166.65.226]:56278 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-04/txt/msg00336.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I noticed that this makes the gdb_assert unreachable. I changed the assert to ">= 0" and moved it before the return. Tom