From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86016 invoked by alias); 19 Oct 2017 21:57:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86004 invoked by uid 89); 19 Oct 2017 21:57:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:352, opportunity X-HELO: gproxy9-pub.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9-pub.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Oct 2017 21:57:20 +0000 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id 772FB1E0CA5 for ; Thu, 19 Oct 2017 15:57:19 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id PZxG1w0052f2jeq01ZxKvN; Thu, 19 Oct 2017 15:57:19 -0600 X-Authority-Analysis: v=2.2 cv=JNNLi4Cb c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=02M-m0pO-4AA:10 a=_ZhYKdCeAAAA:8 a=6BpJsa9WY5CGm6wCRDIA:9 a=uqOk3ZSnBfCTOznnrPA1:22 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:59990 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1e5IoV-002kpB-QO; Thu, 19 Oct 2017 15:57:15 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 3/3] Remove cleanups from break-catch-syscall.c References: <20171018040645.7212-1-tom@tromey.com> <20171018040645.7212-3-tom@tromey.com> Date: Thu, 19 Oct 2017 21:57:00 -0000 In-Reply-To: (Simon Marchi's message of "Thu, 19 Oct 2017 17:00:14 -0400") Message-ID: <877evqssw5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1e5IoV-002kpB-QO X-Source-Sender: 71-218-90-63.hlrn.qwest.net (bapiya) [71.218.90.63]:59990 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-10/txt/msg00649.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Maybe an opportunity to std::move? Alternatively: Simon> holders.emplace_back (string_printf ("group:%s", group_ptr[i])); Simon> group_ptr[i] = holders.back ().c_str (); I made this change. Thanks for noticing this. Tom