Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [RFA 2/2] Remove some clanups from solib-svr4.c
Date: Fri, 30 Mar 2018 19:18:00 -0000	[thread overview]
Message-ID: <877epte5jl.fsf@tromey.com> (raw)
In-Reply-To: <79a2885c006051d0975ef5422d469ceb@polymtl.ca> (Simon Marchi's	message of "Fri, 30 Mar 2018 15:11:58 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> LGTM, I just noted two nits:
[...]

Thanks, I've made these changes and I'm checking it in.

Tom


      reply	other threads:[~2018-03-30 19:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28  4:24 [RFA 0/2] more cleanup removal Tom Tromey
2018-03-28  4:24 ` [RFA 1/2] Change target_read_string to use unique_xmalloc_ptr Tom Tromey
2018-03-30  5:28   ` Simon Marchi
2018-03-28  4:24 ` [RFA 2/2] Remove some clanups from solib-svr4.c Tom Tromey
2018-03-30  5:47   ` Simon Marchi
2018-03-30 19:04     ` Tom Tromey
2018-03-30 19:12       ` Simon Marchi
2018-03-30 19:18         ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877epte5jl.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox