From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106595 invoked by alias); 18 Apr 2018 17:53:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106569 invoked by uid 89); 18 Apr 2018 17:53:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.228) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Apr 2018 17:53:53 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 6C122D4E6D7 for ; Wed, 18 Apr 2018 12:53:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 8rHEftSjIQUwq8rHEffYeh; Wed, 18 Apr 2018 12:53:52 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:38048 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1f8rHD-004Abr-Tb; Wed, 18 Apr 2018 12:53:52 -0500 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/4] Thread language through c_type_print_args References: <20180417195125.14200-1-tom@tromey.com> <20180417195125.14200-3-tom@tromey.com> Date: Wed, 18 Apr 2018 17:53:00 -0000 In-Reply-To: <20180417195125.14200-3-tom@tromey.com> (Tom Tromey's message of "Tue, 17 Apr 2018 13:51:23 -0600") Message-ID: <877ep49z9t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1f8rHD-004Abr-Tb X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:38048 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00373.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> Currently dwarf2read.c will pass the CU's language to Tom> c_type_print_args -- but this doesn't affect all aspects of type Tom> printing, because some code in c-typeprint.c refers to Tom> current_language. Tom> This patch threads the language through more of the type printing Tom> code, adding an overload to c_type_print. Some uses of Tom> current_language remain, but now they are only in top-level functions. Today I was wondering whether it would be better to put the language into the type_print_options. So, I think that is something to consider during review. Tom