From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-146797-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 82001 invoked by alias); 24 Apr 2018 20:23:39 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 81978 invoked by uid 89); 24 Apr 2018 20:23:38 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: gateway20.websitewelcome.com
Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.50.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Apr 2018 20:23:36 +0000
Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6])	by gateway20.websitewelcome.com (Postfix) with ESMTP id 9B9BD400D1C6F	for <gdb-patches@sourceware.org>; Tue, 24 Apr 2018 15:23:35 -0500 (CDT)
Received: from box5379.bluehost.com ([162.241.216.53])	by cmsmtp with SMTP	id B4TPfRSsBQUwqB4TPfCTH8; Tue, 24 Apr 2018 15:23:35 -0500
X-Authority-Reason: nr=8
Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:53278 helo=pokyo)	by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)	(Exim 4.89_1)	(envelope-from <tom@tromey.com>)	id 1fB4TP-0035Qq-CR; Tue, 24 Apr 2018 15:23:35 -0500
From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [RFA 1/6] Add initial type alignment support
References: <20180424152222.8053-1-tom@tromey.com>	<20180424152222.8053-2-tom@tromey.com>	<c46973d1-ab2f-2c50-4272-a6a3bb277b85@redhat.com>
Date: Tue, 24 Apr 2018 20:23:00 -0000
In-Reply-To: <c46973d1-ab2f-2c50-4272-a6a3bb277b85@redhat.com> (Pedro Alves's	message of "Tue, 24 Apr 2018 20:16:53 +0100")
Message-ID: <877eow8ibd.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-BWhitelist: no
X-Source-L: No
X-Exim-ID: 1fB4TP-0035Qq-CR
X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:53278
X-Source-Auth: tom+tromey.com
X-Email-Count: 4
X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20=
X-Local-Domain: yes
X-SW-Source: 2018-04/txt/msg00489.txt.bz2

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> +  if (gdbarch_ptr_bit (gdbarch) == 32 &&
>> +      TYPE_CODE (type) == TYPE_CODE_INT && TYPE_LENGTH (type) > 4)
>> +    return 4;

Pedro> && on the other line.

Hah.  Actually I think I meant to refactor this all a bit and make an
outer if that checked gdbarch_ptr_bit.

Tom