From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39570 invoked by alias); 13 Jul 2018 20:51:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39558 invoked by uid 89); 13 Jul 2018 20:51:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (50.116.125.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jul 2018 20:51:19 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 80989400C84DB for ; Fri, 13 Jul 2018 14:52:38 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id e51tfZde079N3e521fwoi5; Fri, 13 Jul 2018 15:51:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5bg5ZbpRKL5tJzYIgEsRR/Phcj4fRzflRuStbitYlOE=; b=s+cyRREcZQcAvHCVd2J3W2+zAE UjJD3gkh7KXUOZ1iWaucGjLfsxhc7csbVQD/9cPSZYyKJTbJ5gTzWiGXvxMSaBGkxrgxqL89eSfby J91h6fgE4MWySgFUT+pkrynYW; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:34526 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fe51t-001TZJ-9F; Fri, 13 Jul 2018 15:51:05 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 10/13] Remove unused declaration from value.c References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-11-tom@tromey.com> <97a938d0-3cf4-dc2a-b572-6e55b824cf98@simark.ca> Date: Fri, 13 Jul 2018 20:51:00 -0000 In-Reply-To: <97a938d0-3cf4-dc2a-b572-6e55b824cf98@simark.ca> (Simon Marchi's message of "Thu, 12 Jul 2018 22:52:07 -0400") Message-ID: <877elyc11j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00432.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-07-12 04:52 PM, Tom Tromey wrote: >> This removes an unused declaration from value_fetch_lazy_bitfield, but >> leaves the call to check_typedef, because it may be called for effect. Simon> Do you know for sure this is necessary (e.g. without this, some test fails), Simon> or you are just being cautious? Just being cautious. It's entirely possible that this isn't needed. Maybe removing it is correct in that nothing in the function appears to need it, and if it causes a bug then that means that some other spot ought to have called check_typedef. Tom