From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38442 invoked by alias); 9 Aug 2018 20:47:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38432 invoked by uid 89); 9 Aug 2018 20:47:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=judgment, D*fit.cvut.cz, sk:janvra, sk:jan.vra X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.199.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Aug 2018 20:47:26 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 53A63401C787B for ; Thu, 9 Aug 2018 14:50:22 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id nrpxfG6nCbXuJnrq3feq8r; Thu, 09 Aug 2018 15:47:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OcuiOqanTj0SPQhP3lnbxEjg8x3iVJ5JjY7mdklhfN0=; b=J9+7MXRxJK+jVI8b/XIXFkpsi8 DmR1fEu5+fB97nrDtpKWnpbiq3VLWO9eXbFKBcGPhlgz9fL4c4+Br6mNMly7RPZkXYUJcj1r59ccG OwK8M2uN7ugCRJUW4YRzTj18p; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:35714 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fnrpx-002igb-8H; Thu, 09 Aug 2018 15:47:13 -0500 From: Tom Tromey To: Jan Vrany Cc: gdb-patches@sourceware.org Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command References: <87k1pb4dag.fsf@tromey.com> <20180731203424.31866-1-jan.vrany@fit.cvut.cz> Date: Thu, 09 Aug 2018 20:47:00 -0000 In-Reply-To: <20180731203424.31866-1-jan.vrany@fit.cvut.cz> (Jan Vrany's message of "Tue, 31 Jul 2018 21:34:24 +0100") Message-ID: <877ekz6ze7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00240.txt.bz2 >>>>> "Jan" == Jan Vrany writes: Jan> A CLI command "disassemble" allows use to specify a single Jan> address - in that case function surrounding that address is Jan> disassembled. Hi, I didn't see this go in and I thought maybe it needed a new reply? Jan> - if (!((line_seen && file_seen && num_seen && !start_seen && !end_seen) Jan> - || (line_seen && file_seen && !num_seen && !start_seen && !end_seen) Jan> - || (!line_seen && !file_seen && !num_seen && start_seen && end_seen))) Jan> + if (!( ( line_seen && file_seen && !start_seen && !end_seen && !addr_seen) Jan> + || (!line_seen && !file_seen && !num_seen && start_seen && end_seen && !addr_seen) Jan> + || (!line_seen && !file_seen && !num_seen && !start_seen && !end_seen && addr_seen))) These go over 80 columns now, so I think they need to be reformatted somehow to fit. Please use your judgment, what you did here is already better than the status quo... No need to re-post the patch, you can just put it in with the correction. Thank you. Tom