From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94189 invoked by alias); 25 Nov 2018 23:23:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94169 invoked by uid 89); 25 Nov 2018 23:23:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 25 Nov 2018 23:23:29 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBEDE74EE1; Sun, 25 Nov 2018 23:23:27 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7498D5C1B2; Sun, 25 Nov 2018 23:23:27 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: Simon Marchi , GDB Patches , Alan Hayward , nd Subject: Re: [PATCH v2] Implement timestamp'ed output on "make check" References: <20181122221240.15354-1-sergiodj@redhat.com> <20181123150256.22584-1-sergiodj@redhat.com> <61b6c448-bae1-2dd9-87a7-5c500be0aa09@ericsson.com> <87wop13z2z.fsf@redhat.com> <147c28c03427ad7e1e6a9dfd976b027a@polymtl.ca> Date: Sun, 25 Nov 2018 23:23:00 -0000 In-Reply-To: <147c28c03427ad7e1e6a9dfd976b027a@polymtl.ca> (Simon Marchi's message of "Sun, 25 Nov 2018 14:56:32 -0500") Message-ID: <877eh04u8g.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00432.txt.bz2 On Sunday, November 25 2018, Simon Marchi wrote: > On 2018-11-25 11:24, Sergio Durigan Junior wrote: >>> As for the coding style, according to the wiki [1], we should >>> follow PEP8 (which >>> I think makes sense). Can you change your script to folow that? >>> "autopep8 -i print-ts.py" should do it. >> >> Hm, the command doesn't output anything to me, and $? = 0. Is there >> anything in particular that you noticed? > > The command modifies the file in-place, so you should have unstaged > changes after running it. In particular, it should remove spaces > before parentheses. Ah, OK. I'm not used to tools that don't ask me whether I'd like to modify a file. And FWIW, I don't really like this part of PEP8 which states that there should be no spaces before parentheses. Anyway, I've pushed the commit now: f63c03b470036353c8c6c657e15f5ebd62ab67dd Thanks again for the review. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/