From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32899 invoked by alias); 17 Jan 2019 22:21:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32881 invoked by uid 89); 17 Jan 2019 22:21:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Joel, joel X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.67.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Jan 2019 22:21:55 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 55F93400D0587 for ; Thu, 17 Jan 2019 16:21:54 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id kG2sgF7Zo4FKpkG2sgesMh; Thu, 17 Jan 2019 16:21:54 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kOPsNWqUOfhQKXdbb2coo528M06gXH42yiP6/yEOAxg=; b=HthTpEFf4eyJSOW6sCdN+/+KPg jDIcqpmZT5FKnHLqC1r38gnzt/E2i3wwFgzlHCs4kCmDaJ+/Nrlr0brct4OjSeJGN/C3jJzcDjbGR Oc/wqXWOl88ne62eJntWsaVIH; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:47828 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gkG2s-000OOT-4A; Thu, 17 Jan 2019 16:21:54 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFAv2 1/3] Use function_name_style to print Ada and C function names References: <20190112222835.16932-1-philippe.waroquiers@skynet.be> <20190112222835.16932-2-philippe.waroquiers@skynet.be> Date: Thu, 17 Jan 2019 22:21:00 -0000 In-Reply-To: <20190112222835.16932-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 12 Jan 2019 23:28:33 +0100") Message-ID: <877ef2ncvy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00416.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> Note that ada-typeprint.c print_func_type is called with Philippe> types representing functions and is also called to print Philippe> a function NAME and its type. In such a case, the function Philippe> name will be printed using function name style. In this particular spot it still isn't clear to me if this will sometimes style a type name. So, I'm going to defer to Joel on the Ada bits. I'm actually in favor of styling types, but I think they should have a separate setting from functions. Philippe> * ada-typeprint.c (print_func_type): Print function name Philippe> style to print function name. Philippe> * c-typeprint.c (c_print_type_1): Likewise. The c-typeprint.c change is ok. I re-read your last note on the other thread and I think I finally understand. Tom