From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83492 invoked by alias); 3 Jun 2019 16:33:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83484 invoked by uid 89); 3 Jun 2019 16:33:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=former X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Jun 2019 16:33:26 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 602E9B97F for ; Mon, 3 Jun 2019 11:33:25 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Xptlhuz1OiQerXptlhUV7O; Mon, 03 Jun 2019 11:33:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=N0TyTboeJRUEnyZru1V7b5dZfCDiZgBlpCC6cYpVxz4=; b=afSsJcndewi4DyPmMxpRuBpxXI pe9TjKBMNLAYCdx8KZ0XlzHpvFQdowToNajzaEsOp0CwOgu95E7wTVJpLY16Wk2YIRy5pa06Gmm3y 725t4DrCZR71TgOORh5cBdC/N; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:58778 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hXptl-003vGc-3N; Mon, 03 Jun 2019 11:33:25 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC 2/2] Move gdb's xmalloc and friends to new file References: <20190530213046.20542-1-tom@tromey.com> <20190530213046.20542-3-tom@tromey.com> <4042ab05-d68e-15b7-a025-e51b679b376a@simark.ca> Date: Mon, 03 Jun 2019 16:33:00 -0000 In-Reply-To: <4042ab05-d68e-15b7-a025-e51b679b376a@simark.ca> (Simon Marchi's message of "Mon, 3 Jun 2019 11:03:06 -0400") Message-ID: <877ea2och7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00033.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2019-05-30 5:30 p.m., Tom Tromey wrote: >> When "common" becomes a library, linking will cause a symbol clash, >> because "xmalloc" and some related symbols are defined in that >> library, libiberty, and readline. >> >> To work around this problem, this patch moves the clashing symbols to >> a new file, which is then compiled separately for both gdb and >> gdbserver. Simon> Hmm how does this work currently? We have an xmalloc symbols both in Simon> common/common-utils.o and ../libiberty/libiberty.a, why doesn't it clash? If a symbol comes from a .o then it overrides the symbols coming from libraries. The error only occurs if the symbol is only provided by multiple libraries. The former is the case today, because we don't make a library from common/. Tom