From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101180 invoked by alias); 11 Sep 2019 20:16:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101172 invoked by uid 89); 11 Sep 2019 20:16:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=management X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.168.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Sep 2019 20:16:25 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 1233D2C1B for ; Wed, 11 Sep 2019 15:16:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 892OiQvKqdnCe892OilvHN; Wed, 11 Sep 2019 15:16:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+0CEQSCFntFUF53w+iCn6yrM0ain3lw8xVynPYwUrno=; b=N+LLdLH7bCNuzTeefUwRhx+fTf s195abA8gIIrQdYVcdA7wWAZAvgdAuXqrQA0joMGbtX5vbtDsbk/ajyJflPVcXG7y5Jx6Od3HIHmQ 8FnSBH4n8ELpQiecpt2VnA8Dy; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:43322 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i892N-003Vtv-Qz; Wed, 11 Sep 2019 15:16:23 -0500 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH 1/3 v2] Refactor get_init_files to use std::string References: <87o8zs6vpe.fsf@tromey.com> <20190910192304.179191-1-cbiesinger@google.com> Date: Wed, 11 Sep 2019 20:16:00 -0000 In-Reply-To: <20190910192304.179191-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Tue, 10 Sep 2019 14:23:04 -0500") Message-ID: <877e6e4mi1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00208.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> [Thanks, this is the patch with the nits fixed and a couple of other style Christian> changes per your comments on patch 2.] Christian> To avoid manual memory management. Christian> Tested on buildbot. Christian> gdb/ChangeLog: Christian> 2019-09-10 Christian Biesinger Christian> * main.c (get_init_files): Change to use std::string. Christian> (captured_main_1): Update. Christian> (print_gdb_help): Update. FAOD, this is ok. Thank you. Tom