From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93678 invoked by alias); 12 Dec 2019 19:00:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93669 invoked by uid 89); 12 Dec 2019 19:00:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=management X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.159) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Dec 2019 19:00:51 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 0C518400CD41C for ; Thu, 12 Dec 2019 13:00:49 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id fThhib9ujqNtvfThhiJjfb; Thu, 12 Dec 2019 13:00:49 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zsVTn+rM2sNd/Shdxv+izhoQfUTCQw9daMzRAYGOrgk=; b=Cyu9gt1B10bF3+ohPGlbRJcVTP +2rWFl/ZfhnGP92E0cQCbjxPvU6JXYlwP1il3GAhGyAQ2gvfju8TIS0dlSyp7Uq4fbhVPlfioXI7l MQnnx/5ETNFLeaaVhR5hhEmAX; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:39396 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ifThg-0005rQ-Qr; Thu, 12 Dec 2019 12:00:48 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Replace xmalloc/xfree with vector in jit.c References: <20191211063732.1043487-1-simon.marchi@polymtl.ca> Date: Thu, 12 Dec 2019 19:00:00 -0000 In-Reply-To: <20191211063732.1043487-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Wed, 11 Dec 2019 01:37:31 -0500") Message-ID: <877e315py7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00535.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I'm currently studying that code and noticed this manual memory Simon> management, which could easily be replaced with a vector, so here it is. Simon> gdb/ChangeLog: Simon> * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with Simon> gdb::byte_vector. Thanks, this looks good to me. Tom