From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.50.91]) by sourceware.org (Postfix) with ESMTPS id 02367385B835 for ; Thu, 16 Apr 2020 20:07:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 02367385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 5CAF8CBD6 for ; Thu, 16 Apr 2020 15:07:16 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id PAn6jNDu8AGTXPAn6jhzie; Thu, 16 Apr 2020 15:07:16 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=C2UGyLEtS9K1tkpP50STnUPOabwXyLFs0oeRyNL9hgM=; b=ewPHrNmefBmASmzs66QgEBUCZ6 g3CHjgHPAhr2xFqCxshAD+yuep9bbeMdWfrvM5hAlitsJN7WMmQU4Kw3+alB4qU7oupi3AfrkPc8O 2XgRbxXDIRcLXuS0CiWUlSgEl; Received: from 174-16-110-145.hlrn.qwest.net ([174.16.110.145]:46596 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jPAn6-001mDQ-5K; Thu, 16 Apr 2020 14:07:16 -0600 From: Tom Tromey To: Kamil Rytarowski Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Move OpenBSD-only functions from inf-ptrace to obsd-nat References: <20200416165859.10785-1-n54@gmx.com> X-Attribution: Tom Date: Thu, 16 Apr 2020 14:07:15 -0600 In-Reply-To: <20200416165859.10785-1-n54@gmx.com> (Kamil Rytarowski's message of "Thu, 16 Apr 2020 18:58:59 +0200") Message-ID: <877dyf19fw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.110.145 X-Source-L: No X-Exim-ID: 1jPAn6-001mDQ-5K X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-110-145.hlrn.qwest.net (murgatroyd) [174.16.110.145]:46596 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, TXREP, T_SPF_TEMPERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 20:07:27 -0000 >>>>> ">" == Kamil Rytarowski writes: >> All major BSDs implement PT_GET_PROCESS_STATE, but they differ in >> details and want to implement follow-fork functionality differently. >> gdb/ChangeLog: >> * inf-ptrace.h (follow_fork, insert_fork_catchpoint) >> (remove_fork_catchpoint, post_startup_inferior) >> (post_attach): Move... I guess these aren't used on Linux, but what about rs6000-nat.c? Those are the only non-BSD users of inf_ptrace_target that I can see. I'm not a big fan of the current code, because makes methods conditional on this define. It would be better I guess to have an intermediate subclass for this situation. That would make it clear what code does or does not rely on this. You don't have to do that, but I don't think we can put this in without knowing about the rs6000-nat case. Tom