From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.47.179]) by sourceware.org (Postfix) with ESMTPS id 467983887010 for ; Wed, 20 May 2020 19:36:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 467983887010 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id A8CED6543 for ; Wed, 20 May 2020 14:36:14 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id bUVijhK1AEfyqbUVijRGaZ; Wed, 20 May 2020 14:36:14 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qbjOBQZYdcPW6gFTdp/ybHEC0gqNRfrK0u07BIV1LBU=; b=DoiSBN1FDLJh1jqNeqQZ6Rc8+p uI6jztmNoDjDtkrn/bFS05be5ywk7LSD/qLaufv8qVvYvsYSVmnzfZx+nTEzxpWHYv/WnlTgUp18R ad2VaPkYiC3X1tGoLGQ7JPGrZ; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:51246 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jbUVi-003sBw-DE; Wed, 20 May 2020 13:36:14 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb: reset/recompute objfile section offsets in reread_symbols References: <20200520192226.2889993-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 20 May 2020 13:36:12 -0600 In-Reply-To: <20200520192226.2889993-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Wed, 20 May 2020 15:22:26 -0400") Message-ID: <877dx6o0ur.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jbUVi-003sBw-DE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:51246 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2020 19:36:16 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> This patch fixes this by making reread_symbols clear the Simon> `section_offsets` vector, and re-create it by calling `sym_offsets`. Simon> This is analogous to what syms_from_objfile_1 does. I didn't seem Simon> absolutely necessary, but I also made it clear the various Simon> `sect_index_*` fields, since their values no longer make sense (they Simon> describe the old executable, and are indices in the now cleared Simon> sections/section_offsets arrays). This makes sense to me. Simon> I don't really like the approach taken by reread_symbols, trying to Simon> reset everything manually on the objfile object, instead of, for Simon> example, creating a new one from scratch. A long time ago, Jan had a patch to do exactly this. I couldn't easily find it; there was some opposition to it at the time, but I still think it's a better approach. thanks, Tom