From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ludo@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 510A63858D34
 for <gdb-patches@sourceware.org>; Fri,  3 Jul 2020 07:06:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 510A63858D34
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ludo@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:49098)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@gnu.org>)
 id 1jrFm4-0002Iz-Hx; Fri, 03 Jul 2020 03:06:16 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60200 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@gnu.org>)
 id 1jrFlz-0002nz-0f; Fri, 03 Jul 2020 03:06:14 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 1/2] guile: Add support for Guile 2.2.
References: <87v9jbi855.fsf@gnu.org> <20200628142540.11320-1-ludo@gnu.org>
 <c582adaf-b260-3fa1-bfa1-8870efedebc1@simark.ca>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 16 Messidor an 228 de la =?utf-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Fri, 03 Jul 2020 09:06:08 +0200
In-Reply-To: <c582adaf-b260-3fa1-bfa1-8870efedebc1@simark.ca> (Simon Marchi's
 message of "Thu, 2 Jul 2020 20:31:45 -0400")
Message-ID: <877dvloz6n.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jul 2020 07:06:19 -0000

Hi Simon,

Simon Marchi <simark@simark.ca> skribis:

> On 2020-06-28 10:25 a.m., Ludovic Court=C3=A8s wrote:
>> This primarily updates code that uses the I/O port API of Guile.
>
> I know nothing about Guile, so I just scanned the patch for any obvious
> red flags, but didn't see any.  The mess of #if statements sure is not
> the best, but I don't have a concrete suggestion to make it better.

I agree the #ifdefs are not pretty, but it=E2=80=99s a temporary measure un=
til
GDB 11 when Guile 2.0 support will be dropped.

Thanks for taking a look!

Ludo=E2=80=99.