From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wBsUIfMsKGDLdwAAWB0awg (envelope-from ) for ; Sat, 13 Feb 2021 14:48:03 -0500 Received: by simark.ca (Postfix, from userid 112) id 7A3861EF68; Sat, 13 Feb 2021 14:48:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 001EA1E789 for ; Sat, 13 Feb 2021 14:48:02 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8823D3857005; Sat, 13 Feb 2021 19:48:02 +0000 (GMT) Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.50.73]) by sourceware.org (Postfix) with ESMTPS id 283B23857005 for ; Sat, 13 Feb 2021 19:47:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 283B23857005 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway24.websitewelcome.com (Postfix) with ESMTP id B338B3694 for ; Sat, 13 Feb 2021 13:47:50 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id B0tSlUgvQSrGMB0tSl3q3J; Sat, 13 Feb 2021 13:47:50 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3O4uR5l3kMGo2OqRZg3lN+iVWY9oej8mRU0wFbEmQIU=; b=yisXy5lDN3JB67G6THQIf1ceEh wASieTWJDdAdOlLNWkRGxa54Uk0CkCUQqWB7GsTPmWNQl87ug8By2oPZ4i/pDrNNbTCCXfcOeVy60 /AQrRzdf3PD31QkjpkK/cYQfo; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:52408 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lB0tS-001Xzm-DX; Sat, 13 Feb 2021 12:47:50 -0700 From: Tom Tromey To: Joel Brobecker Subject: Re: [PATCH 151/203] Split out some Ada type resolution code References: <20210101214723.1784144-1-tom@tromey.com> <20210101214723.1784144-152-tom@tromey.com> <20210103074649.GB363503@adacore.com> X-Attribution: Tom Date: Sat, 13 Feb 2021 12:47:49 -0700 In-Reply-To: <20210103074649.GB363503@adacore.com> (Joel Brobecker's message of "Sun, 3 Jan 2021 11:46:49 +0400") Message-ID: <877dnbvjfe.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1lB0tS-001Xzm-DX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (localhost.localdomain) [97.122.91.54]:52408 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Joel" == Joel Brobecker writes: Joel> Hi Tom, Joel> On Fri, Jan 01, 2021 at 02:46:31PM -0700, Tom Tromey wrote: >> This splits some Ada type resolution code out of resolve_subexp into >> new functions that can be reused. >> >> gdb/ChangeLog >> 2021-01-01 Tom Tromey >> >> * ada-lang.h (ada_find_operator_symbol, ada_resolve_funcall) >> (ada_resolve_variable): Declare. >> * ada-lang.c (ada_find_operator_symbol, ada_resolve_funcall) >> (ada_resolve_variable): New functions. >> (resolve_subexp): Update. Joel> Could this patch go in early, and independently of this patch series Joel> (or perhaps right after the first third of the patches splitting Joel> the various eval routines go in)? It could but it's simpler for me to keep the series as-is. Joel> As far as I can tell, all it needs is documentation of the new routines Joel> in ada-lang.h. Other than that, this patch looks like a nice little Joel> improvement of the code's organization. I've added some comments. Tom