From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5WpUKHXukmBrCwAAWB0awg (envelope-from ) for ; Wed, 05 May 2021 15:13:57 -0400 Received: by simark.ca (Postfix, from userid 112) id 9DA241F11C; Wed, 5 May 2021 15:13:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 924911E54D for ; Wed, 5 May 2021 15:13:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 599EE3857C60; Wed, 5 May 2021 19:13:56 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.145.9]) by sourceware.org (Postfix) with ESMTPS id 9B13B3857C60 for ; Wed, 5 May 2021 19:13:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9B13B3857C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 3DF245B120D for ; Wed, 5 May 2021 14:13:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id eMy1lx6czPkfteMy1lzaex; Wed, 05 May 2021 14:13:53 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ng1J3PUhVWKzY1RD+yHXdoIKn+BA9RV+o5KNR5MPFSY=; b=D4N/qFRPQejasz1xxRXz+7gUtN gXgLuSwOqlhguVtnnA/5N7LP10C+c70rMJfFVGLgPmh9I2b7fqkGDX7+ypG8UFyAg4UqXK3NBs4Cf q+N2q+bZGwtKMRCl+cmNNfv9U; Received: from 97-122-70-176.hlrn.qwest.net ([97.122.70.176]:60790 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1leMy0-000tLZ-VG; Wed, 05 May 2021 13:13:53 -0600 From: Tom Tromey To: Mike Frysinger via Gdb-patches Subject: Re: [PATCH] sim: m32c/rl78/rx: fix command parsing References: <87k0odqe9w.fsf@tromey.com> <20210505190220.28848-1-vapier@gentoo.org> X-Attribution: Tom Date: Wed, 05 May 2021 13:13:52 -0600 In-Reply-To: <20210505190220.28848-1-vapier@gentoo.org> (Mike Frysinger via Gdb-patches's message of "Wed, 5 May 2021 15:02:20 -0400") Message-ID: <877dkdq9hr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.176 X-Source-L: No X-Exim-ID: 1leMy0-000tLZ-VG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-176.hlrn.qwest.net (murgatroyd) [97.122.70.176]:60790 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Mike" == Mike Frysinger via Gdb-patches writes: Mike> Use buildargv to avoid writing to const memory and freeing invalid Mike> pointers, and to avoid doing any string parsing ourselves. Thank you. Mike> + char **argv = buildargv (cmd); Mike> + cmd = argv[0]; Mike> + arg = argv[1]; I think this should also check that argv[0] and argv[1] != NULL somewhere. Otherwise malformed commands like "monitor" or "monitor trace" may crash. Tom