From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qo8CDHEyvmD1MgAAWB0awg (envelope-from ) for ; Mon, 07 Jun 2021 10:51:29 -0400 Received: by simark.ca (Postfix, from userid 112) id 22FCA1F163; Mon, 7 Jun 2021 10:51:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9041B1E813 for ; Mon, 7 Jun 2021 10:51:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 046E3388A415 for ; Mon, 7 Jun 2021 14:51:25 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.80]) by sourceware.org (Postfix) with ESMTPS id ADD10383800F for ; Mon, 7 Jun 2021 14:51:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ADD10383800F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 191839AF6E for ; Mon, 7 Jun 2021 09:50:57 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qGafliY8qMGeEqGafla36q; Mon, 07 Jun 2021 09:50:57 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=A7xdkCounzD0sypnC5E84StuAjMVPmkhZEOR6kedhIE=; b=Oze0Uql6KSLM1l+3p0jfcN62B+ UC9B7hBGxnIKcg87jH9KZ6OqqKPXaRz7Ss5MR7OY/CAJuXElvUb9WjwhZtjkKC7deZcKebrs7fprd dFCOXyE4xZq6xHYyaQAWrs18j; Received: from 97-122-81-113.hlrn.qwest.net ([97.122.81.113]:50752 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lqGae-003lwg-Rn; Mon, 07 Jun 2021 08:50:56 -0600 From: Tom Tromey To: Andrew Burgess Subject: Re: [PATCH 1/5] gdb/python: handle saving user registers in a frame unwinder References: X-Attribution: Tom Date: Mon, 07 Jun 2021 08:50:56 -0600 In-Reply-To: (Andrew Burgess's message of "Sat, 29 May 2021 21:57:10 +0100") Message-ID: <877dj5n2y7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.113 X-Source-L: No X-Exim-ID: 1lqGae-003lwg-Rn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-113.hlrn.qwest.net (murgatroyd) [97.122.81.113]:50752 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Andrew" == Andrew Burgess writes: Andrew> So, in this patch I propose that in the unwinder code, when Andrew> add_saved_register is called, if it is passed a Andrew> user-register (i.e. non-cooked) then we first fetch the register, Andrew> extract the real register number from the value's location, and use Andrew> that new register number when handling the add_saved_register call. Andrew> If either the value location that we get for the user-register is not Andrew> a cooked register then we can throw a 'Bad register' error back to the Andrew> Python code, but in most cases this will not happen. I was worried that requesting this would require unwinding the register, which is what is currently being done. But I suppose the idea is that the value is normally lazy, so it isn't actually unwound? Tom