From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JpwpEovIMWJlKAAAWB0awg (envelope-from ) for ; Wed, 16 Mar 2022 07:22:51 -0400 Received: by simark.ca (Postfix, from userid 112) id 3859A1F3CC; Wed, 16 Mar 2022 07:22:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 889A91EDF0 for ; Wed, 16 Mar 2022 07:22:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BE65E3864C15 for ; Wed, 16 Mar 2022 11:22:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE65E3864C15 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1647429769; bh=b4otH0+Cqe0M4OhLeptUmhITsRvRm1GQrN+k+Ytb390=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nwx7hjz4Ay4LITmYwrtafLpeNB/kDIXm07EO6qllwfX5gS8smbieiNspRVTiEnvmj fg6N7w50mQa6YqVclvL8/Q4cen4BAK+9q8QJuoyIok390NZ0hoyCfpu3aHPTVaTZc2 bbYAhwx0UxK3g26Hh1vvZjsOXgoHAO+NlPs2oMZI= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0704A386549C for ; Wed, 16 Mar 2022 11:22:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0704A386549C Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-376-wYgtSyMdMXyVqtSCAnMRUA-1; Wed, 16 Mar 2022 07:22:29 -0400 X-MC-Unique: wYgtSyMdMXyVqtSCAnMRUA-1 Received: by mail-wm1-f69.google.com with SMTP id q6-20020a1cf306000000b0038c5726365aso936943wmq.3 for ; Wed, 16 Mar 2022 04:22:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=b4otH0+Cqe0M4OhLeptUmhITsRvRm1GQrN+k+Ytb390=; b=CIsmyaZ/a4pF/nkGyePEWTByPrwqckmMSvwkeDU9KQcoB7RCWlK5RQNoQGVS1unwFy QA8n9FILXcW9lBkhk5AMvu8E6y1IOZU5qHfCdkgwcRd+puuBW7DcT6MddNSZOPWAbxQe DdPUDClpkVcYW6Us4Blok/nC2s1RnfoplOt/z0AnkkEj3d/GFG3WlW6zD73dmh6z+tyk pQzzsimgm2jVpgnFptvs8dcH40FOAqGSVNjxYVbFaEdPVG2YcVFH8Y3N8iLFtfgD9F3W XarwgDFZJysnhT5addE24Csb7ls6D5esSfZrZtsU4sjXsA37TzWxAKf5VNT4I1Xr7bLE 2N4w== X-Gm-Message-State: AOAM532M3mDOy9J+fD85lyNk9JEn0Z/GXieNAkYKTU/sTeBBgsNDJM4Z 1AjyqQsZX557gQNbSjW3FQbVJvi/y5BA9po4DYK07XI6nJQvKQKdHyydTE/jVDeOclc0SAS5DlY B0licTz9B4Wk6KmUOnbkRJw== X-Received: by 2002:adf:9123:0:b0:1ef:9b6d:60c1 with SMTP id j32-20020adf9123000000b001ef9b6d60c1mr23662365wrj.169.1647429748328; Wed, 16 Mar 2022 04:22:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFQf5n2D3U9PQHj4LAmLr90MABNWO/kLCNnhx10JNg163UbHs0vwaLS0dCMoaqIBy23dOK3A== X-Received: by 2002:adf:9123:0:b0:1ef:9b6d:60c1 with SMTP id j32-20020adf9123000000b001ef9b6d60c1mr23662349wrj.169.1647429748128; Wed, 16 Mar 2022 04:22:28 -0700 (PDT) Received: from localhost (host109-154-72-186.range109-154.btcentralplus.com. [109.154.72.186]) by smtp.gmail.com with ESMTPSA id o7-20020a5d6707000000b001f067c7b47fsm2047866wru.27.2022.03.16.04.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 04:22:27 -0700 (PDT) To: Youling Tang , Lancelot SIX Subject: Re: [PATCH] gdb: mips: Fix the handling of complex type of function return value In-Reply-To: References: <1647406106-25723-1-git-send-email-tangyouling@loongson.cn> <20220316084248.m5m2et3njtngeoge@Plymouth> Date: Wed, 16 Mar 2022 11:22:27 +0000 Message-ID: <877d8uuop8.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Youling Tang writes: > Hi, Lancelo > > On 03/16/2022 04:42 PM, Lancelot SIX wrote: >> On Wed, Mar 16, 2022 at 12:48:26PM +0800, Youling Tang wrote: >>> $ objdump -d outputs/gdb.base/varargs/varargs >>> 00000001200012e8 : >>> ... >>> 1200013b8: c7c10000 lwc1 $f1,0(s8) >>> 1200013bc: c7c00004 lwc1 $f0,4(s8) >>> 1200013c0: 46000886 mov.s $f2,$f1 >>> 1200013c4: 46000046 mov.s $f1,$f0 >>> 1200013c8: 46001006 mov.s $f0,$f2 >>> 1200013cc: 46000886 mov.s $f2,$f1 >>> 1200013d0: 03c0e825 move sp,s8 >>> 1200013d4: dfbe0038 ld s8,56(sp) >>> 1200013d8: 67bd0080 daddiu sp,sp,128 >>> 1200013dc: 03e00008 jr ra >>> 1200013e0: 00000000 nop >>> >>> From the above disassembly, we can see that when the return value of the >>> function is a complex type and len <= 2 * MIPS64_REGSIZE, the return value >>> will be passed through $f0 and $f2, so fix the corresponding processing >>> in mips_n32n64_return_value(). >>> >>> $ make check RUNTESTFLAGS='GDB=../gdb gdb.base/varargs.exp --outdir=test' >>> >>> Before applying the patch: >>> FAIL: gdb.base/varargs.exp: print find_max_float_real(4, fc1, fc2, fc3, fc4) >>> FAIL: gdb.base/varargs.exp: print find_max_double_real(4, dc1, dc2, dc3, dc4) >>> >>> # of expected passes 9 >>> # of unexpected failures 2 >>> >>> After applying the patch: >>> # of expected passes 11 >>> >>> Signed-off-by: Youling Tang >>> --- >>> gdb/mips-tdep.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c >>> index 7e37578..cddb8f8 100644 >>> --- a/gdb/mips-tdep.c >>> +++ b/gdb/mips-tdep.c >>> @@ -5224,9 +5224,10 @@ mips_n32n64_return_value (struct gdbarch *gdbarch, struct value *function, >>> >>> if (TYPE_LENGTH (type) > 2 * MIPS64_REGSIZE) >>> return RETURN_VALUE_STRUCT_CONVENTION; >>> - else if (type->code () == TYPE_CODE_FLT >>> + else if ((type->code () == TYPE_CODE_FLT >>> && TYPE_LENGTH (type) == 16 >>> && tdep->mips_fpu_type != MIPS_FPU_NONE) >> Hi, >> >> Just minor note, those 2 lines above should be indented 2 more space I >> think (so the && operator continues to vertically align with "type->code >> ()"). >> >>> + || (type->code () == TYPE_CODE_COMPLEX)) >> I do not think the extra set of parens are requires (but they do no harm >> either). > Ok, I will modify this code style in the next version. This change looks good to me with the style adjusments that Lancelot pointed out. Thanks, Andrew