From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2spKMQ7KNGKxGwAAWB0awg (envelope-from ) for ; Fri, 18 Mar 2022 14:06:06 -0400 Received: by simark.ca (Postfix, from userid 112) id 8FB041F3CC; Fri, 18 Mar 2022 14:06:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 113041EDF0 for ; Fri, 18 Mar 2022 14:06:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 417043889806 for ; Fri, 18 Mar 2022 18:06:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 417043889806 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1647626765; bh=7VshpNICdB8W86OcPmhf96dLMG/EB+U3Ncv6fdrLwH4=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=PHK4rvQLsLLrfLoTOF1mBpY3OpiqYHwlziStIYCkPOj/N+u4y9BEw3pDS8gH5gl92 SOKvCDHrUKqdcj5LBoAiMSm+ItwY8bQIiLNxbvPAuRrV61KMou/AnoLgkFIFzZHrz2 qSWnu3jwqRpN/OviID1znCcG7/MrG0KvDQdtoX90= Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id 103033888825 for ; Fri, 18 Mar 2022 18:05:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 103033888825 Received: by mail-il1-x132.google.com with SMTP id x9so6354468ilc.3 for ; Fri, 18 Mar 2022 11:05:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7VshpNICdB8W86OcPmhf96dLMG/EB+U3Ncv6fdrLwH4=; b=cmaEExC8UYcESibOrHztjki3uLBnurL22XuetWPn2Tp+ICtGUZ1EDmI4Dr9t7FxuDb KkZS2H0hwBupcDYBfkAWrmPd3585HekGGycJLbpAavNH2U/AOnYcYoiIQkeu1Dpw0PUx pCjsuGj4P+aGBbo8DeV++SBOtyhHSagZruS6l+2ijioKFmIhwkxOeQnV1RhuGcbBO9xX S3LFtaIuKfIAJjXEJmp0R4rop94q+LU8eAcDLZ7ChE3FEeFAxb0/Mp9Iw5FQC62VNDRP og0vXSd7JzH6EczHVtlktopcuzvWHds46VNY0c8ZeTkO/1M9aWXVodWUh6Ux9SeVwfqX MU3A== X-Gm-Message-State: AOAM531xan2UVtOYQUu1YZh7HCKSWBweLOU6PyMUm2yHgqdGm9x/7wfp oUylOmI+D3SZYT0dIQVFbapLaUTld4pbZA== X-Google-Smtp-Source: ABdhPJy4k8/xpS4UAj0xx+618FmoHXKmsBZaNTNSOubf5rgM2bmk1+5d6V8gWBR3Sao9jU7lz3pjKQ== X-Received: by 2002:a05:6e02:1b8a:b0:2c7:6aeb:c5f7 with SMTP id h10-20020a056e021b8a00b002c76aebc5f7mr4708598ili.135.1647626745364; Fri, 18 Mar 2022 11:05:45 -0700 (PDT) Received: from murgatroyd (71-211-175-224.hlrn.qwest.net. [71.211.175.224]) by smtp.gmail.com with ESMTPSA id a6-20020a92c546000000b002c7a44bf1a5sm5269292ilj.48.2022.03.18.11.05.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 11:05:44 -0700 (PDT) To: Luis Machado Subject: Re: [PATCH 2/3] Implement real literal extension for Ada References: <20220301170055.1520935-1-tromey@adacore.com> <20220301170055.1520935-3-tromey@adacore.com> <77f98638-ec8f-5d79-8a00-d91db1253644@arm.com> X-Attribution: Tom Date: Fri, 18 Mar 2022 12:05:44 -0600 In-Reply-To: <77f98638-ec8f-5d79-8a00-d91db1253644@arm.com> (Luis Machado's message of "Wed, 16 Mar 2022 14:33:01 +0000") Message-ID: <877d8ri1af.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom Tromey via Gdb-patches Reply-To: Tom Tromey Cc: gdb-patches@sourceware.org, Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Luis" == Luis Machado writes: Luis> I think the floating point representations may differ between Luis> architectures/bit-sizes. Luis> I noticed 5 failures in this test for aarch64-linux and arm-linux. This is interesting, because internally we have a rewrite of this same test, and it seems fine on aarch64-linux. Luis> FAIL: gdb.ada/float-bits.exp: print 16llf#7FFFF7FF4054A56FA5B99019A5C8# Luis> FAIL: gdb.ada/float-bits.exp: print val_long_double Luis> FAIL: gdb.ada/float-bits.exp: print val_long_double := Luis> 16llf#7FFFF7FF4054A56FA5B99019A5C8# Luis> FAIL: gdb.ada/float-bits.exp: print val_long_double after assignment Luis> FAIL: gdb.ada/float-bits.exp: print Luis> Some of the expected values don't really match. If the output is Luis> supposed to differ, maybe we should compare hex values instead? I'm curious what is show by 'print/x' of the various values in there. Luis> Also, for 32-bit targets, I'm seeing size-related issues. We're also doing testing on ARM and that seems fine. I did disable some of these internally for some targets, ones with "weird" floating point. Anyway, it seems like we could change the test to verify that the size of each floating point type is what's expected before proceeding. But I'd like to understand the above a bit better, first. thanks, Tom